From dbessono at openjdk.org  Fri Jan 10 18:20:57 2025
From: dbessono at openjdk.org (Dmitry Bessonov)
Date: Fri, 10 Jan 2025 18:20:57 GMT
Subject: RFR: 7903842: Negative coverage in report for records
In-Reply-To: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
References: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
Message-ID: <VNvMnYrLJ5rNT7m5Ny09FkDMiCYGC8R_ew6PzLVydKM=.6e7c3fb2-7056-479e-b936-d935c46c37fc@github.com>

On Mon, 7 Oct 2024 20:10:03 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> The Javap report had several issues marked in the picture below, which have been fixed:
> ![defectReport](https://github.com/user-attachments/assets/b8de7fc9-c59b-41f9-8300-700a1e24b533)
> The expected report is:
> ![fixedReport](https://github.com/user-attachments/assets/e7aa1ef4-3bed-46d8-80eb-a6e2c87a6da2)

While not being deep in the context it seems that the report body was not reworked to show something else than code lines containing code instructions. The report still renders lines marked as green or red, not the specific instructions highlighted in green or red.  

Another thing to note is that the reported bug looks related to incorrect calculations, not to the column naming. So any suggested renaming might better go under a different suggested enhancement?

-------------

PR Comment: https://git.openjdk.org/jcov/pull/48#issuecomment-2583465391

From shurailine at openjdk.org  Wed Jan 22 21:30:01 2025
From: shurailine at openjdk.org (Alexandre Iline)
Date: Wed, 22 Jan 2025 21:30:01 GMT
Subject: RFR: 7903842: Negative coverage in report for records
In-Reply-To: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
References: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
Message-ID: <3FhdMmLja4OXn2h7Z8No-ixxt8ennO_ZnMFqWhtCKZQ=.c7039e72-d111-4526-b8be-b15e55c7d07d@github.com>

On Mon, 7 Oct 2024 20:10:03 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> The Javap report had several issues marked in the picture below, which have been fixed:
> ![defectReport](https://github.com/user-attachments/assets/b8de7fc9-c59b-41f9-8300-700a1e24b533)
> The expected report is:
> ![fixedReport](https://github.com/user-attachments/assets/e7aa1ef4-3bed-46d8-80eb-a6e2c87a6da2)

I will create an additional enhance request to rename column "line coverage" to "instruction coverage"

-------------

Marked as reviewed by shurailine (Reviewer).

PR Review: https://git.openjdk.org/jcov/pull/48#pullrequestreview-2568314229

From lkuskov at openjdk.org  Wed Jan 22 21:38:59 2025
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Wed, 22 Jan 2025 21:38:59 GMT
Subject: Integrated: 7903842: Negative coverage in report for records
In-Reply-To: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
References: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
Message-ID: <odX-OcsOM1rc4yeDAtGSCULgR8QuEL9y_yGaorrSzAo=.beb3ecdc-1d2e-430f-af55-4d0a406af73f@github.com>

On Mon, 7 Oct 2024 20:10:03 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> The Javap report had several issues marked in the picture below, which have been fixed:
> ![defectReport](https://github.com/user-attachments/assets/b8de7fc9-c59b-41f9-8300-700a1e24b533)
> The expected report is:
> ![fixedReport](https://github.com/user-attachments/assets/e7aa1ef4-3bed-46d8-80eb-a6e2c87a6da2)

This pull request has now been integrated.

Changeset: 6ce973f5
Author:    Leonid Kuskov <lkuskov at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/6ce973f5066ef5b6199bb809269c6f029dd81526
Stats:     541 lines in 11 files changed: 187 ins; 155 del; 199 mod

7903842: Negative coverage in report for records

Reviewed-by: shurailine

-------------

PR: https://git.openjdk.org/jcov/pull/48

From shurailine at openjdk.org  Wed Jan 22 21:44:59 2025
From: shurailine at openjdk.org (Alexandre Iline)
Date: Wed, 22 Jan 2025 21:44:59 GMT
Subject: RFR: 7903842: Negative coverage in report for records
In-Reply-To: <VNvMnYrLJ5rNT7m5Ny09FkDMiCYGC8R_ew6PzLVydKM=.6e7c3fb2-7056-479e-b936-d935c46c37fc@github.com>
References: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
 <VNvMnYrLJ5rNT7m5Ny09FkDMiCYGC8R_ew6PzLVydKM=.6e7c3fb2-7056-479e-b936-d935c46c37fc@github.com>
Message-ID: <JDFU5bg7Hab22-P2M2VYRppd1P65pgs8B2opVDMjLgE=.eaa17478-1f76-4852-ac8b-79800011fd80@github.com>

On Fri, 10 Jan 2025 18:18:07 GMT, Dmitry Bessonov <dbessono at openjdk.org> wrote:

> While not being deep in the context it seems that the report body was not reworked to show something else than code lines

@dbessono , the report is reworked to show a different number in the header. Changing the column name therefore is logical.

I have created an enhancement for this change, to unblock @lkuskov : https://bugs.openjdk.org/browse/CODETOOLS-7903938

-------------

PR Comment: https://git.openjdk.org/jcov/pull/48#issuecomment-2608330693

From shurailine at openjdk.org  Thu Jan 23 19:04:02 2025
From: shurailine at openjdk.org (Alexandre Iline)
Date: Thu, 23 Jan 2025 19:04:02 GMT
Subject: RFR: 7903842: Negative coverage in report for records
In-Reply-To: <0g5VseiKhxdyUPFboePjpmmH0ojUJInc68KNgu2qntY=.bd526a6c-ec1d-41be-846c-f082249c7d97@github.com>
References: <osOtSuNxX1uid2ooUuzo0jRE-6gN62ArnFgEI2wA6Us=.7c05336b-4071-49cd-882a-0557091ca1d5@github.com>
 <0g5VseiKhxdyUPFboePjpmmH0ojUJInc68KNgu2qntY=.bd526a6c-ec1d-41be-846c-f082249c7d97@github.com>
Message-ID: <tKWWXQrLQlNIvr8NtS2_R-AKBBovmXZk4Jbxiybns3w=.36463929-dc56-473e-bef8-cf35e8663b2c@github.com>

On Fri, 20 Dec 2024 19:56:01 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

>> The Javap report had several issues marked in the picture below, which have been fixed:
>> ![defectReport](https://github.com/user-attachments/assets/b8de7fc9-c59b-41f9-8300-700a1e24b533)
>> The expected report is:
>> ![fixedReport](https://github.com/user-attachments/assets/e7aa1ef4-3bed-46d8-80eb-a6e2c87a6da2)
>
> The term 'code line' (line of 4.7.3. The Code Attribute) or the simplified 'line' is intuitively clear and sufficient to be used there. All lines that can't be covered in the javap report don't have green or red markings like comment lines in Java sources and are clearly excluded from the meaning of covered/non-covered.

Also created https://bugs.openjdk.org/browse/CODETOOLS-7903939 so it is not forgotten. @lkuskov

-------------

PR Comment: https://git.openjdk.org/jcov/pull/48#issuecomment-2610789099