From lkuskov at openjdk.org  Tue Jul  1 00:27:49 2025
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 1 Jul 2025 00:27:49 GMT
Subject: RFR: 7904052: Allow JCov tests to be run by JTReg
In-Reply-To: <IUrxszXkyQwlyKk4B2buiNVz9bzwXPgJlIcAcrqaYkM=.894596e0-1e18-4cf7-bc7e-091b0d227f73@github.com>
References: <IUrxszXkyQwlyKk4B2buiNVz9bzwXPgJlIcAcrqaYkM=.894596e0-1e18-4cf7-bc7e-091b0d227f73@github.com>
Message-ID: <ZYh8suBYfAQ-f2edfuGckRAh0XBZ8vyF8gZqd8Wd_6c=.449c4651-1650-4fe9-9595-452b782e4e32@github.com>

On Mon, 30 Jun 2025 22:46:03 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> JCov provides better isolation and better control over the execution environment.
> For now I kept the testng test subject, up for discussion.

LGTM

-------------

Marked as reviewed by lkuskov (Reviewer).

PR Review: https://git.openjdk.org/jcov/pull/63#pullrequestreview-2973128385

From shurailine at openjdk.org  Tue Jul  1 00:53:50 2025
From: shurailine at openjdk.org (Alexandre Iline)
Date: Tue, 1 Jul 2025 00:53:50 GMT
Subject: Integrated: 7904052: Allow JCov tests to be run by JTReg
In-Reply-To: <IUrxszXkyQwlyKk4B2buiNVz9bzwXPgJlIcAcrqaYkM=.894596e0-1e18-4cf7-bc7e-091b0d227f73@github.com>
References: <IUrxszXkyQwlyKk4B2buiNVz9bzwXPgJlIcAcrqaYkM=.894596e0-1e18-4cf7-bc7e-091b0d227f73@github.com>
Message-ID: <41HAh4cqLfblLzzYcWjFRaRYVLlDK3s7FbKTa2unQeI=.7991f0f9-b9e1-40d8-9f33-d10b277d74e9@github.com>

On Mon, 30 Jun 2025 22:46:03 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> JCov provides better isolation and better control over the execution environment.
> For now I kept the testng test subject, up for discussion.

This pull request has now been integrated.

Changeset: a48fd09d
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/a48fd09dbc21607414c4018d7028809024532e2a
Stats:     13 lines in 2 files changed: 13 ins; 0 del; 0 mod

7904052: Allow JCov tests to be run by JTReg

Reviewed-by: lkuskov

-------------

PR: https://git.openjdk.org/jcov/pull/63

From shurailine at openjdk.org  Fri Jul 11 23:28:29 2025
From: shurailine at openjdk.org (Alexandre Iline)
Date: Fri, 11 Jul 2025 23:28:29 GMT
Subject: RFR: 7904066: Make some plugin tests runnable with JTReg
Message-ID: <2Qme-Aj9FjrygCe3NPF__V6eTkqrsoFJWiilnd0phhE=.e2fa7fa2-31de-45a6-a96d-b74a90c16c31@github.com>

Adding necessary TEST.ROOT files.
Fixing up a few tests.
Fixing a problem in the code.

-------------

Commit messages:
 - CODETOOLS-7904066: Make some plugin tests runnable with JTReg

Changes: https://git.openjdk.org/jcov/pull/64/files
  Webrev: https://webrevs.openjdk.org/?repo=jcov&pr=64&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904066
  Stats: 100 lines in 7 files changed: 78 ins; 6 del; 16 mod
  Patch: https://git.openjdk.org/jcov/pull/64.diff
  Fetch: git fetch https://git.openjdk.org/jcov.git pull/64/head:pull/64

PR: https://git.openjdk.org/jcov/pull/64

From shurailine at openjdk.org  Fri Jul 11 23:34:49 2025
From: shurailine at openjdk.org (Alexandre Iline)
Date: Fri, 11 Jul 2025 23:34:49 GMT
Subject: RFR: 7904066: Make some plugin tests runnable with JTReg
In-Reply-To: <2Qme-Aj9FjrygCe3NPF__V6eTkqrsoFJWiilnd0phhE=.e2fa7fa2-31de-45a6-a96d-b74a90c16c31@github.com>
References: <2Qme-Aj9FjrygCe3NPF__V6eTkqrsoFJWiilnd0phhE=.e2fa7fa2-31de-45a6-a96d-b74a90c16c31@github.com>
Message-ID: <XhZSgw05ZUpyZoiOCfRiUvTtQJjBCti4UvXe3pnyJWE=.59824c88-8de8-47a6-9753-2702d6af663f@github.com>

On Fri, 11 Jul 2025 23:23:24 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Adding necessary TEST.ROOT files.
> Fixing up a few tests.
> Fixing a problem in the code.

plugins/coverage_reports/src/openjdk/codetools/jcov/report/jcov/JCovCoverageComparison.java line 102:

> 100:                         var isOldMethod = oldSource == null || oldMethodsCache.containsKey(id);
> 101:                         DataMethod oldMethod = isOldMethod ? oldMethodsCache.get(id) : null;
> 102:                         var newLineCoverage = new MethodCoverage(newMethod, false).getLineCoverage();

@lkuskov 

Regarding this and similar changes in the files.
The countBlocks parameter: https://github.com/openjdk/jcov/blob/a48fd09dbc21607414c4018d7028809024532e2a/src/classes/com/sun/tdk/jcov/report/MethodCoverage.java#L59
was set to "true" everywhere in the coverage reports plugin. However, in the next constructor it is interpreted as "javapCoverage": https://github.com/openjdk/jcov/blob/a48fd09dbc21607414c4018d7028809024532e2a/src/classes/com/sun/tdk/jcov/report/MethodCoverage.java#L68C54-L68C63

Is counting blocks equivalent to generating Java reports, or how do I interpret this?

I am guessing this is the outcome from your recent javap report fixup.

I have changed all the values to false because what I need in the reports is line coverage.

Can you advise?

-------------

PR Review Comment: https://git.openjdk.org/jcov/pull/64#discussion_r2202059199

From lkuskov at openjdk.org  Mon Jul 14 18:21:58 2025
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Mon, 14 Jul 2025 18:21:58 GMT
Subject: RFR: 7904066: Make some plugin tests runnable with JTReg
In-Reply-To: <2Qme-Aj9FjrygCe3NPF__V6eTkqrsoFJWiilnd0phhE=.e2fa7fa2-31de-45a6-a96d-b74a90c16c31@github.com>
References: <2Qme-Aj9FjrygCe3NPF__V6eTkqrsoFJWiilnd0phhE=.e2fa7fa2-31de-45a6-a96d-b74a90c16c31@github.com>
Message-ID: <Rt1ufREnkPR_EwCQmvwx-VJOMN-kBzKpLU9kjIdl_60=.2afe85d5-e69f-4318-8add-39e0e5ddb56b@github.com>

On Fri, 11 Jul 2025 23:23:24 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Adding necessary TEST.ROOT files.
> Fixing up a few tests.
> Fixing a problem in the code.

Marked as reviewed by lkuskov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jcov/pull/64#pullrequestreview-3017334503

From lkuskov at openjdk.org  Mon Jul 14 18:21:58 2025
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Mon, 14 Jul 2025 18:21:58 GMT
Subject: RFR: 7904066: Make some plugin tests runnable with JTReg
In-Reply-To: <XhZSgw05ZUpyZoiOCfRiUvTtQJjBCti4UvXe3pnyJWE=.59824c88-8de8-47a6-9753-2702d6af663f@github.com>
References: <2Qme-Aj9FjrygCe3NPF__V6eTkqrsoFJWiilnd0phhE=.e2fa7fa2-31de-45a6-a96d-b74a90c16c31@github.com>
 <XhZSgw05ZUpyZoiOCfRiUvTtQJjBCti4UvXe3pnyJWE=.59824c88-8de8-47a6-9753-2702d6af663f@github.com>
Message-ID: <lO7F6lfHlbsvX8qvkmCDBk2lcBLmKXtBYHL_Uy8FfLU=.ca118b65-6a54-45e5-bde0-1dfe54e7e941@github.com>

On Fri, 11 Jul 2025 23:30:58 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

>> Adding necessary TEST.ROOT files.
>> Fixing up a few tests.
>> Fixing a problem in the code.
>
> plugins/coverage_reports/src/openjdk/codetools/jcov/report/jcov/JCovCoverageComparison.java line 102:
> 
>> 100:                         var isOldMethod = oldSource == null || oldMethodsCache.containsKey(id);
>> 101:                         DataMethod oldMethod = isOldMethod ? oldMethodsCache.get(id) : null;
>> 102:                         var newLineCoverage = new MethodCoverage(newMethod, false).getLineCoverage();
> 
> @lkuskov 
> 
> Regarding this and similar changes in the files.
> The countBlocks parameter: https://github.com/openjdk/jcov/blob/a48fd09dbc21607414c4018d7028809024532e2a/src/classes/com/sun/tdk/jcov/report/MethodCoverage.java#L59
> was set to "true" everywhere in the coverage reports plugin. However, in the next constructor it is interpreted as "javapCoverage": https://github.com/openjdk/jcov/blob/a48fd09dbc21607414c4018d7028809024532e2a/src/classes/com/sun/tdk/jcov/report/MethodCoverage.java#L68C54-L68C63
> 
> Is counting blocks equivalent to generating Java reports, or how do I interpret this?
> 
> I am guessing this is the outcome from your recent javap report fixup.
> 
> I have changed all the values to false because what I need in the reports is line coverage.
> 
> Can you advise?

The parameter countBlocks, which was never actually used, was repurposed as an indicator for javapReporting.
Jcov's functionality did not change, and the reporting system did not lose its ability to generate all types of reports.
 The fix LGTM

-------------

PR Review Comment: https://git.openjdk.org/jcov/pull/64#discussion_r2205535780

From shurailine at openjdk.org  Mon Jul 14 18:26:58 2025
From: shurailine at openjdk.org (Alexandre Iline)
Date: Mon, 14 Jul 2025 18:26:58 GMT
Subject: Integrated: 7904066: Make some plugin tests runnable with JTReg
In-Reply-To: <2Qme-Aj9FjrygCe3NPF__V6eTkqrsoFJWiilnd0phhE=.e2fa7fa2-31de-45a6-a96d-b74a90c16c31@github.com>
References: <2Qme-Aj9FjrygCe3NPF__V6eTkqrsoFJWiilnd0phhE=.e2fa7fa2-31de-45a6-a96d-b74a90c16c31@github.com>
Message-ID: <p8OOBomdDG7gDChtrWfRKDObrvaxty1GbIhya2_I4kk=.6c6a7a6b-c770-481a-90b0-2e4cd7f50255@github.com>

On Fri, 11 Jul 2025 23:23:24 GMT, Alexandre Iline <shurailine at openjdk.org> wrote:

> Adding necessary TEST.ROOT files.
> Fixing up a few tests.
> Fixing a problem in the code.

This pull request has now been integrated.

Changeset: 54b769b3
Author:    Alexandre Iline <shurailine at openjdk.org>
URL:       https://git.openjdk.org/jcov/commit/54b769b3d8cf339941d980e71b3cd55b3f7f69b4
Stats:     100 lines in 7 files changed: 78 ins; 6 del; 16 mod

7904066: Make some plugin tests runnable with JTReg

Reviewed-by: lkuskov

-------------

PR: https://git.openjdk.org/jcov/pull/64