JCStress HTML output: clarification on Failed vs Error

[Gilles Duboscq]

Hello,

I find the HTML output a bit confusing regarding the usage of the words
"failed" and "error".

If i understand correctly, the result "ERROR" can be interpreted as "this
test could not be run to completion" while "FAILED" is "this test ran to
completion but the results are in violation of what was expected".

The confusing thing is that the HTML output lists the tests with *errors*
under the "Failed tests" section while the *failed* tests are not listed
there.

I think the patch below would make things clearer.

Also it may be useful to have a quick summary of the *failed* tests.

-Gilles

diff -r 39ce92f75ef3
harness/src/main/java/org/openjdk/jcstress/infra/grading/HTMLReportPrinter.java
---
a/harness/src/main/java/org/openjdk/jcstress/infra/grading/HTMLReportPrinter.java
Thu
Nov 28 19:50:40 2013 +0400
+++
b/harness/src/main/java/org/openjdk/jcstress/infra/grading/HTMLReportPrinter.java
Wed
Dec 18 14:03:17 2013 +0100
@@ -248,7 +247,7 @@
         output.println("</tr>");
         output.println("</table>");

-        printFailedTests(results, packages, output);
+        printErrorTests(results, packages, output);
         printSpecTests(results, packages, output);
         printInterestingTests(results, packages, output);
         printAllTests(results, packages, output);
@@ -259,8 +258,8 @@
         output.close();
     }

-    private void printFailedTests(Map<String, TestResult> results,
Multimap<String, String> packages, PrintWriter output) throws
FileNotFoundException, JAXBException {
-        output.println("<h3>Failed tests</h3>");
+    private void printErrorTests(Map<String, TestResult> results,
Multimap<String, String> packages, PrintWriter output) throws
FileNotFoundException, JAXBException {
+        output.println("<h3>Tests which could not be run:</h3>");
         output.println("<table cellspacing=0 cellpadding=0
width=\"100%\">");

         boolean hadAnyTests = false;
@@ -276,7 +275,7 @@
                         emitPackage(output, k);
                         packageEmitted = true;
                     }
-                    emitTestFailure(output, result, test);
+                    emitTestError(output, result, test);
                     hadAnyTests = true;
                 }
             }
@@ -375,7 +374,7 @@
                 if (result.status() == Status.NORMAL) {
                     emitTest(output, result, test);
                 } else {
-                    emitTestFailure(output, result, test);
+                    emitTestError(output, result, test);
                 }

                 PrintWriter local = new PrintWriter(resultDir + "/" +
testName + ".html");
@@ -435,7 +434,7 @@
         output.println("</tr>");
     }

-    public void emitTestFailure(PrintWriter output, TestResult result,
Test description) throws FileNotFoundException, JAXBException {
+    public void emitTestError(PrintWriter output, TestResult result, Test
description) throws FileNotFoundException, JAXBException {
         cellStyle = 3 - cellStyle;
         output.println("<tr class=\"cell" + cellStyle + "\">");
         output.println("<td>&nbsp;&nbsp;&nbsp;<a href=\"" +
result.getName() + ".html\">" + cutKlass(result.getName()) + "</a></td>");