Jcstress jopt-simple question

[Jerzy Krolak]

This patch puts jopt-simple inside jcstress jar, and relocates the package
into 'shaded.*'.

There's a downside, though - the produced jcstress-core pom.xml will not
contain any comments. Including the Oracle copyright notice.

Thanks,
Jerzy

2018-01-15 16:10 GMT+01:00 Aleksey Shipilev <shade at redhat.com>:

> Hi,
>
> On 12/29/2017 09:46 PM, Jerzy Krolak wrote:
> > I recently ran a jcstress benchmark against an application, that already
> had a newer jopt-simple
> > lib. And I had a conflict.
> >
> > Do you think we could repackage the jopt-simple classes to a package
> like 'shaded.joptsimple.*' and
> > include this straight in the jcstress-core? maven-shade-plugin should do
> the trick.
> >
> > I thought of a few ways to handle this, but shading seemed to have least
> side effects.
> >
> > What do you think? I'll submit a patch, if you like the idea.
>
> Yes, I think that would be a wise thing to do.
>
> Thanks,
> -Aleksey
>
>
>
-------------- next part --------------
diff -r 18db5d6682d7 jcstress-core/pom.xml
--- a/jcstress-core/pom.xml	Thu Nov 16 16:45:28 2017 +0100
+++ b/jcstress-core/pom.xml	Thu Jan 18 20:59:26 2018 +0100
@@ -132,6 +132,27 @@
                 </executions>
             </plugin>
             <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-shade-plugin</artifactId>
+                <version>3.1.0</version>
+                <executions>
+                    <execution>
+                        <phase>package</phase>
+                        <goals>
+                            <goal>shade</goal>
+                        </goals>
+                        <configuration>
+                            <relocations>
+                                <relocation>
+                                    <pattern>joptsimple</pattern>
+                                    <shadedPattern>shaded.joptsimple</shadedPattern>
+                                </relocation>
+                            </relocations>
+                        </configuration>
+                    </execution>
+                </executions>
+            </plugin>
+            <plugin>
                 <groupId>org.codehaus.mojo</groupId>
                 <artifactId>build-helper-maven-plugin</artifactId>
                 <executions>