From shade at openjdk.java.net Mon May 3 16:26:07 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 3 May 2021 16:26:07 GMT Subject: RFR: CODETOOLS-7902914: jcstress: Remove Whitebox and deoptimization support Message-ID: jcstress had online deoptimization support since very beginning. It was there to hopefully improve the randomization story: with fuzzers, online deoptimization can perform many compilations in a single VM. This is now better catered by multiple forks, which allows to capture the randomization seeds for better replication, makes the VM outputs relate to one compilation session only, etc. Therefore, Whitebox support and the related infra can be removed to ease maintenance. This also gives a test time boost on very short workloads. ------------- Commit messages: - Remove Whitebox and deoptimization support Changes: https://git.openjdk.java.net/jcstress/pull/43/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=43&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902914 Stats: 420 lines in 13 files changed: 0 ins; 419 del; 1 mod Patch: https://git.openjdk.java.net/jcstress/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/43/head:pull/43 PR: https://git.openjdk.java.net/jcstress/pull/43 From duke at openjdk.java.net Mon May 3 16:45:38 2021 From: duke at openjdk.java.net (duke) Date: Mon, 3 May 2021 16:45:38 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902914: jcstress: Remove Whitebox and deoptimization support Message-ID: <121c935b-9d7e-4ef2-b245-57702df50e74@openjdk.java.net> Changeset: 138160ba Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-03 18:44:51 +0000 URL: https://git.openjdk.java.net/jcstress/commit/138160ba87a4e269cbc1009cbc8d731715aaa645 CODETOOLS-7902914: jcstress: Remove Whitebox and deoptimization support ! jcstress-core/pom.xml - jcstress-core/src/assembly/whitebox.xml ! jcstress-core/src/main/java/org/openjdk/jcstress/ForkedMain.java ! jcstress-core/src/main/java/org/openjdk/jcstress/Options.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/processors/JCStressTestProcessor.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/Runner.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/TestConfig.java - jcstress-core/src/main/java/org/openjdk/jcstress/vm/DeoptAllTestMain.java - jcstress-core/src/main/java/org/openjdk/jcstress/vm/DeoptMethodTestMain.java - jcstress-core/src/main/java/org/openjdk/jcstress/vm/DeoptMode.java ! jcstress-core/src/main/java/org/openjdk/jcstress/vm/VMSupport.java - jcstress-core/src/main/java/org/openjdk/jcstress/vm/WhiteBoxSupport.java - jcstress-core/src/main/java/sun/hotspot/WhiteBox.java From shade at openjdk.java.net Mon May 3 16:47:59 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Mon, 3 May 2021 16:47:59 GMT Subject: Withdrawn: CODETOOLS-7902914: jcstress: Remove Whitebox and deoptimization support In-Reply-To: References: Message-ID: On Mon, 3 May 2021 16:21:44 GMT, Aleksey Shipilev wrote: > jcstress had online deoptimization support since very beginning. It was there to hopefully improve the randomization story: with fuzzers, online deoptimization can perform many compilations in a single VM. This is now better catered by multiple forks, which allows to capture the randomization seeds for better replication, makes the VM outputs relate to one compilation session only, etc. > > Therefore, Whitebox support and the related infra can be removed to ease maintenance. This also gives a test time boost on very short workloads. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/43 From shade at openjdk.java.net Tue May 4 09:09:14 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 09:09:14 GMT Subject: RFR: CODETOOLS-7902916: jcstress: Pass a limited subset of TestConfig to the forked VMs Message-ID: <3GTTV4neeHNCXqq1UGqtXh96O_q_9mRrsByb7Ot9Fz0=.33f8c0ad-9a39-47b2-8410-0e7de533a3fb@github.com> Current TestConfig is serialized and passed in full to the forked VMs. It carries a lot of baggage that forked VM does not really care about. We can instead pass a very limited subset of it. It also opens the way to use the small non-Java-Serialization format later. ------------- Commit messages: - Fixes - More improvements - More improvements - Split out ForkedTestConfig Changes: https://git.openjdk.java.net/jcstress/pull/44/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=44&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902916 Stats: 214 lines in 12 files changed: 113 ins; 70 del; 31 mod Patch: https://git.openjdk.java.net/jcstress/pull/44.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/44/head:pull/44 PR: https://git.openjdk.java.net/jcstress/pull/44 From duke at openjdk.java.net Tue May 4 09:31:44 2021 From: duke at openjdk.java.net (duke) Date: Tue, 4 May 2021 09:31:44 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902916: jcstress: Pass a limited subset of TestConfig to the forked VMs Message-ID: <02159b2e-3ee5-43f6-9e7c-84c6d110dc32@openjdk.java.net> Changeset: e6f83a90 Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-04 11:31:21 +0000 URL: https://git.openjdk.java.net/jcstress/commit/e6f83a902973aeeb95aada731162565df1f3c8ec CODETOOLS-7902916: jcstress: Pass a limited subset of TestConfig to the forked VMs ! jcstress-core/src/main/java/org/openjdk/jcstress/ForkedMain.java ! jcstress-core/src/main/java/org/openjdk/jcstress/TestExecutor.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/collectors/TestResult.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/grading/ReportUtils.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/processors/JCStressTestProcessor.java + jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/ForkedTestConfig.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/Runner.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/TestConfig.java ! jcstress-core/src/main/java/org/openjdk/jcstress/link/BinaryLinkClient.java ! jcstress-core/src/main/java/org/openjdk/jcstress/link/BinaryLinkServer.java ! jcstress-core/src/main/java/org/openjdk/jcstress/link/JobResponseFrame.java ! jcstress-core/src/main/java/org/openjdk/jcstress/link/ServerListener.java From shade at openjdk.java.net Tue May 4 09:33:59 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 09:33:59 GMT Subject: Withdrawn: CODETOOLS-7902916: jcstress: Pass a limited subset of TestConfig to the forked VMs In-Reply-To: <3GTTV4neeHNCXqq1UGqtXh96O_q_9mRrsByb7Ot9Fz0=.33f8c0ad-9a39-47b2-8410-0e7de533a3fb@github.com> References: <3GTTV4neeHNCXqq1UGqtXh96O_q_9mRrsByb7Ot9Fz0=.33f8c0ad-9a39-47b2-8410-0e7de533a3fb@github.com> Message-ID: On Tue, 4 May 2021 09:04:50 GMT, Aleksey Shipilev wrote: > Current TestConfig is serialized and passed in full to the forked VMs. It carries a lot of baggage that forked VM does not really care about. We can instead pass a very limited subset of it. It also opens the way to use the small non-Java-Serialization format later. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/44 From shade at openjdk.java.net Tue May 4 11:24:13 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 11:24:13 GMT Subject: RFR: CODETOOLS-7902917: jcstress: Errors during interruption tests Message-ID: This is a regression since CODETOOLS-7902906. The interruption tests would never reply the result, because they call System.exit(0) before binary link is able to push the result. ------------- Commit messages: - Fix interrupt tests Changes: https://git.openjdk.java.net/jcstress/pull/45/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=45&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902917 Stats: 19 lines in 3 files changed: 16 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/jcstress/pull/45.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/45/head:pull/45 PR: https://git.openjdk.java.net/jcstress/pull/45 From duke at openjdk.java.net Tue May 4 11:41:24 2021 From: duke at openjdk.java.net (duke) Date: Tue, 4 May 2021 11:41:24 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902917: jcstress: Errors during interruption tests Message-ID: <7b850ac0-fc87-4bc1-a7aa-a751d39050a4@openjdk.java.net> Changeset: e962c1b1 Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-04 13:41:12 +0000 URL: https://git.openjdk.java.net/jcstress/commit/e962c1b11bc9492b7988adfe4652c03b72ed4550 CODETOOLS-7902917: jcstress: Errors during interruption tests ! jcstress-core/src/main/java/org/openjdk/jcstress/ForkedMain.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/processors/JCStressTestProcessor.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/Runner.java From shade at openjdk.java.net Tue May 4 11:43:58 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 11:43:58 GMT Subject: Withdrawn: CODETOOLS-7902917: jcstress: Errors during interruption tests In-Reply-To: References: Message-ID: On Tue, 4 May 2021 11:19:34 GMT, Aleksey Shipilev wrote: > This is a regression since CODETOOLS-7902906. The interruption tests would never reply the result, because they call System.exit(0) before binary link is able to push the result. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/45 From shade at openjdk.java.net Tue May 4 12:48:12 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 12:48:12 GMT Subject: RFR: CODETOOLS-7902918: jcstress: Replace the relevant uses of HashMultiset with Counter Message-ID: <0YhLgshGjw56ZsgmTWNKAUD0WrstLnQcMf9YLIIPADs=.539f1df4-c7e7-4fc9-9ee8-a5e583c9dfe7@github.com> High-performance parts of jcstress code use open-address Counter to store state data. There is no reason why we cannot use Counter in the TestResults themselves. ------------- Commit messages: - Replace HashMultiset with Counter - Merge branch 'master' into multiset-to-counter - Merge branch 'master' into multiset-to-counter - Custom serializer for Counter - Replace HashMultiset with Counter Changes: https://git.openjdk.java.net/jcstress/pull/46/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=46&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902918 Stats: 116 lines in 4 files changed: 79 ins; 20 del; 17 mod Patch: https://git.openjdk.java.net/jcstress/pull/46.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/46/head:pull/46 PR: https://git.openjdk.java.net/jcstress/pull/46 From duke at openjdk.java.net Tue May 4 13:01:32 2021 From: duke at openjdk.java.net (duke) Date: Tue, 4 May 2021 13:01:32 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902918: jcstress: Replace the relevant uses of HashMultiset with Counter Message-ID: <6b4c1750-a084-4e50-8102-e0d058bf11da@openjdk.java.net> Changeset: 5012b897 Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-04 15:00:54 +0000 URL: https://git.openjdk.java.net/jcstress/commit/5012b897e4e667fc4601770fa43247451b3e0b1d CODETOOLS-7902918: jcstress: Replace the relevant uses of HashMultiset with Counter ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/collectors/TestResult.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/grading/ReportUtils.java ! jcstress-core/src/main/java/org/openjdk/jcstress/util/Counter.java ! jcstress-core/src/test/java/org/openjdk/jcstress/util/CounterTest.java From shade at openjdk.java.net Tue May 4 13:03:56 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 13:03:56 GMT Subject: Withdrawn: CODETOOLS-7902918: jcstress: Replace the relevant uses of HashMultiset with Counter In-Reply-To: <0YhLgshGjw56ZsgmTWNKAUD0WrstLnQcMf9YLIIPADs=.539f1df4-c7e7-4fc9-9ee8-a5e583c9dfe7@github.com> References: <0YhLgshGjw56ZsgmTWNKAUD0WrstLnQcMf9YLIIPADs=.539f1df4-c7e7-4fc9-9ee8-a5e583c9dfe7@github.com> Message-ID: On Tue, 4 May 2021 12:42:24 GMT, Aleksey Shipilev wrote: > High-performance parts of jcstress code use open-address Counter to store state data. There is no reason why we cannot use Counter in the TestResults themselves. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/46 From shade at openjdk.java.net Tue May 4 14:12:14 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 14:12:14 GMT Subject: RFR: CODETOOLS-7902919: jcstress: Sysfs topology parser fails due to oddly intersecting core IDs Message-ID: The sysfs parser is still incomplete: it tries to generate synthetic core IDs when they appear to belong to different packages. In doing so, it multiplies by the number of packages -- which is incorrect, and we should multiply at least by the max number of cores per package. We might as well multiply by the number of CPUs to be on the safe side. ------------- Commit messages: - Attempt: make sure synthetic core IDs never intersect, multiply by the number of CPUs - Test cases Changes: https://git.openjdk.java.net/jcstress/pull/47/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=47&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902919 Stats: 381 lines in 6 files changed: 369 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jcstress/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/47/head:pull/47 PR: https://git.openjdk.java.net/jcstress/pull/47 From cgo at openjdk.java.net Tue May 4 14:29:59 2021 From: cgo at openjdk.java.net (Christoph =?UTF-8?B?R8O2dHRzY2hrZXM=?=) Date: Tue, 4 May 2021 14:29:59 GMT Subject: RFR: CODETOOLS-7902919: jcstress: Sysfs topology parser fails due to oddly intersecting core IDs In-Reply-To: References: Message-ID: On Tue, 4 May 2021 14:07:38 GMT, Aleksey Shipilev wrote: > The sysfs parser is still incomplete: it tries to generate synthetic core IDs when they appear to belong to different packages. In doing so, it multiplies by the number of packages -- which is incorrect, and we should multiply at least by the max number of cores per package. We might as well multiply by the number of CPUs to be on the safe side. Thanks a lot for the fast fix. Sadly, the `test_Current` of `LinuxProcfsTopologyTest` still fails on that machine: test_Current(org.openjdk.jcstress.os.topology.LinuxProcfsTopologyTest) Time elapsed: 0.03 sec <<< ERROR! org.openjdk.jcstress.os.topology.TopologyParseException: Core belongs to different packages: P1, C0, T1, 0 at org.openjdk.jcstress.os.topology.AbstractTopology.add(AbstractTopology.java:78) at org.openjdk.jcstress.os.topology.LinuxProcfsTopology.(LinuxProcfsTopology.java:61) at org.openjdk.jcstress.os.topology.LinuxProcfsTopology.(LinuxProcfsTopology.java:41) at org.openjdk.jcstress.os.topology.LinuxProcfsTopologyTest.test_Current(LinuxProcfsTopologyTest.java:22) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) `lscpu` reports: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 38 bits physical, 48 bits virtual CPU(s): 8 On-line CPU(s) list: 0-7 Thread(s) per core: 1 Core(s) per socket: 4 Socket(s): 2 NUMA node(s): 1 Vendor ID: GenuineIntel CPU family: 6 Model: 23 Model name: Intel(R) Xeon(R) CPU E5440 @ 2.83GHz Stepping: 6 CPU MHz: 1994.891 CPU max MHz: 2833.0000 CPU min MHz: 2000.0000 BogoMIPS: 5652.19 Virtualization: VT-x L1d cache: 256 KiB L1i cache: 256 KiB L2 cache: 24 MiB NUMA node0 CPU(s): 0-7 Vulnerability Itlb multihit: KVM: Mitigation: Split huge pages Vulnerability L1tf: Mitigation; PTE Inversion; VMX EPT disabled Vulnerability Mds: Vulnerable: Clear CPU buffers attempted, no microcode; SMT disabled Vulnerability Meltdown: Mitigation; PTI Vulnerability Spec store bypass: Vulnerable Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Full generic retpoline, STIBP disabled, RSB filling Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts rep_good nopl cpuid aperfmperf pni dtes6 4 monitor ds_cpl vmx est tm2 ssse3 cx16 xtpr pdcm dca sse4_1 lahf_lm pti tpr_shadow vnmi flexpriority dtherm This looks like your test is correct. ------------- PR: https://git.openjdk.java.net/jcstress/pull/47 From shade at openjdk.java.net Tue May 4 14:39:14 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 14:39:14 GMT Subject: RFR: CODETOOLS-7902919: jcstress: Sysfs topology parser fails due to oddly intersecting core IDs [v2] In-Reply-To: References: Message-ID: > The sysfs parser is still incomplete: it tries to generate synthetic core IDs when they appear to belong to different packages. In doing so, it multiplies by the number of packages -- which is incorrect, and we should multiply at least by the max number of cores per package. We might as well multiply by the number of CPUs to be on the safe side. Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Cannot expect LinuxProcfs to always succeed on all build environments ------------- Changes: - all: https://git.openjdk.java.net/jcstress/pull/47/files - new: https://git.openjdk.java.net/jcstress/pull/47/files/257634b8..41a2e38a Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jcstress&pr=47&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jcstress&pr=47&range=00-01 Stats: 6 lines in 1 file changed: 1 ins; 4 del; 1 mod Patch: https://git.openjdk.java.net/jcstress/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/47/head:pull/47 PR: https://git.openjdk.java.net/jcstress/pull/47 From shade at openjdk.java.net Tue May 4 14:39:14 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 14:39:14 GMT Subject: RFR: CODETOOLS-7902919: jcstress: Sysfs topology parser fails due to oddly intersecting core IDs In-Reply-To: References: Message-ID: On Tue, 4 May 2021 14:27:37 GMT, Christoph G?ttschkes wrote: > Thanks a lot for the fast fix. Sadly, the `test_Current` of `LinuxProcfsTopologyTest` still fails on that machine: Ah yes. We cannot expect it to pass on all build environments. That test is actually for debugging purposes, so I added `@Ignore` to it. It should now pass. ------------- PR: https://git.openjdk.java.net/jcstress/pull/47 From cgo at openjdk.java.net Tue May 4 15:09:01 2021 From: cgo at openjdk.java.net (Christoph =?UTF-8?B?R8O2dHRzY2hrZXM=?=) Date: Tue, 4 May 2021 15:09:01 GMT Subject: RFR: CODETOOLS-7902919: jcstress: Sysfs topology parser fails due to oddly intersecting core IDs In-Reply-To: References: Message-ID: On Tue, 4 May 2021 14:36:08 GMT, Aleksey Shipilev wrote: > Ah yes. We cannot expect it to pass on all build environments. That test is actually for debugging purposes, so I added @Ignore to it. It should now pass. Oh, that got me confused, I first thought the failing test was again for the `LinuxSysfsTopology`, but it is for `procfs`. I tested again and the build now succeeds for OpenJDK 11 and 16. Thanks a lot. Sorry, but I am not at all familiar with the code base and can not comment on the change itself. It looks reasonable to me and while investigating the source of the issue, I expected the problem to be what you changed. ------------- PR: https://git.openjdk.java.net/jcstress/pull/47 From duke at openjdk.java.net Tue May 4 16:27:37 2021 From: duke at openjdk.java.net (duke) Date: Tue, 4 May 2021 16:27:37 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902919: jcstress: Sysfs topology parser fails due to oddly intersecting core IDs Message-ID: <06f2d10b-f768-41d6-9194-324f58acbb12@openjdk.java.net> Changeset: 62381f71 Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-04 18:27:02 +0000 URL: https://git.openjdk.java.net/jcstress/commit/62381f713b20e5be0335a5b9c9d0eba2fa54f6b6 CODETOOLS-7902919: jcstress: Sysfs topology parser fails due to oddly intersecting core IDs ! jcstress-core/src/main/java/org/openjdk/jcstress/os/topology/AbstractTopology.java ! jcstress-core/src/main/java/org/openjdk/jcstress/os/topology/LinuxSysfsTopology.java ! jcstress-core/src/test/java/org/openjdk/jcstress/os/topology/LinuxProcfsTopologyTest.java ! jcstress-core/src/test/java/org/openjdk/jcstress/os/topology/LinuxSysfsTopologyTest.java + jcstress-core/src/test/resources/topology/cpuinfo-7.txt + jcstress-core/src/test/resources/topology/sysfs-7.txt From shade at openjdk.java.net Tue May 4 16:29:59 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 16:29:59 GMT Subject: Withdrawn: CODETOOLS-7902919: jcstress: Sysfs topology parser fails due to oddly intersecting core IDs In-Reply-To: References: Message-ID: On Tue, 4 May 2021 14:07:38 GMT, Aleksey Shipilev wrote: > The sysfs parser is still incomplete: it tries to generate synthetic core IDs when they appear to belong to different packages. In doing so, it multiplies by the number of packages -- which is incorrect, and we should multiply at least by the max number of cores per package. We might as well multiply by the number of CPUs to be on the safe side. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/47 From shade at openjdk.java.net Tue May 4 17:28:16 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 17:28:16 GMT Subject: RFR: CODETOOLS-7902920: jcstress: Rework binary link client/server for lower latency Message-ID: Profiling of current "-m sanity" runs shows that we are spending 10..100ms per JVM in dealing with Java serialization and network transfers. Since the binary link is rather simple, we can hand-craft a binary protocol that would alleviate these costs. ------------- Commit messages: - Revert unnecessary BinaryLinkServer changes - Touchups - Remove Java serialization from the binary link - Merge branch 'master' into network-tune - Reworking - Merge branch 'master' into network-tune - More improvements - Pump the server acceptors - More improvements - Network updates Changes: https://git.openjdk.java.net/jcstress/pull/48/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=48&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902920 Stats: 477 lines in 15 files changed: 165 ins; 256 del; 56 mod Patch: https://git.openjdk.java.net/jcstress/pull/48.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/48/head:pull/48 PR: https://git.openjdk.java.net/jcstress/pull/48 From shade at openjdk.java.net Tue May 4 17:36:24 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 17:36:24 GMT Subject: RFR: CODETOOLS-7902920: jcstress: Rework binary link client/server for lower latency [v2] In-Reply-To: References: Message-ID: > Profiling of current "-m sanity" runs shows that we are spending 10..100ms per JVM in dealing with Java serialization and network transfers. Since the binary link is rather simple, we can hand-craft a binary protocol that would alleviate these costs. Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision: Revert unnecessary changes ------------- Changes: - all: https://git.openjdk.java.net/jcstress/pull/48/files - new: https://git.openjdk.java.net/jcstress/pull/48/files/f9f9bd3b..7acdd913 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jcstress&pr=48&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jcstress&pr=48&range=00-01 Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jcstress/pull/48.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/48/head:pull/48 PR: https://git.openjdk.java.net/jcstress/pull/48 From duke at openjdk.java.net Tue May 4 17:56:01 2021 From: duke at openjdk.java.net (duke) Date: Tue, 4 May 2021 17:56:01 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902920: jcstress: Rework binary link client/server for lower latency Message-ID: <4f89ec4d-ad87-44ae-9baf-e6b4d3554ced@openjdk.java.net> Changeset: b23f688e Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-04 19:55:46 +0000 URL: https://git.openjdk.java.net/jcstress/commit/b23f688e30c3e90e5beb44b68932be872fe6a54c CODETOOLS-7902920: jcstress: Rework binary link client/server for lower latency ! jcstress-core/src/main/java/org/openjdk/jcstress/ForkedMain.java ! jcstress-core/src/main/java/org/openjdk/jcstress/TestExecutor.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/collectors/TestResult.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/ForkedTestConfig.java ! jcstress-core/src/main/java/org/openjdk/jcstress/link/BinaryLinkClient.java ! jcstress-core/src/main/java/org/openjdk/jcstress/link/BinaryLinkServer.java - jcstress-core/src/main/java/org/openjdk/jcstress/link/FinishingFrame.java - jcstress-core/src/main/java/org/openjdk/jcstress/link/JobRequestFrame.java - jcstress-core/src/main/java/org/openjdk/jcstress/link/JobResponseFrame.java - jcstress-core/src/main/java/org/openjdk/jcstress/link/OkResponseFrame.java + jcstress-core/src/main/java/org/openjdk/jcstress/link/Protocol.java - jcstress-core/src/main/java/org/openjdk/jcstress/link/ResultsFrame.java ! jcstress-core/src/main/java/org/openjdk/jcstress/link/ServerListener.java - jcstress-core/src/main/java/org/openjdk/jcstress/link/WTFWasThatFrame.java ! jcstress-core/src/main/java/org/openjdk/jcstress/util/Counter.java From shade at openjdk.java.net Tue May 4 17:58:01 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 4 May 2021 17:58:01 GMT Subject: Withdrawn: CODETOOLS-7902920: jcstress: Rework binary link client/server for lower latency In-Reply-To: References: Message-ID: On Tue, 4 May 2021 17:24:08 GMT, Aleksey Shipilev wrote: > Profiling of current "-m sanity" runs shows that we are spending 10..100ms per JVM in dealing with Java serialization and network transfers. Since the binary link is rather simple, we can hand-craft a binary protocol that would alleviate these costs. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/48 From shade at openjdk.java.net Wed May 5 07:01:15 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 5 May 2021 07:01:15 GMT Subject: RFR: CODETOOLS-7902921: jcstress: Pre-warmup affinity support and thread pools Message-ID: Profiling for "-m sanity" runs shows that we spend considerable amount of time doing the first-use initialization of AffinitySupport in the worker threads. We can make it better by offloading that first initialization to the worker task that runs during the rest of the infra initialization. ------------- Commit messages: - Pre-warmup Changes: https://git.openjdk.java.net/jcstress/pull/49/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=49&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902921 Stats: 50 lines in 1 file changed: 38 ins; 12 del; 0 mod Patch: https://git.openjdk.java.net/jcstress/pull/49.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/49/head:pull/49 PR: https://git.openjdk.java.net/jcstress/pull/49 From duke at openjdk.java.net Wed May 5 07:31:37 2021 From: duke at openjdk.java.net (duke) Date: Wed, 5 May 2021 07:31:37 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902921: jcstress: Pre-warmup affinity support and thread pools Message-ID: Changeset: 17f407c9 Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-05 09:30:58 +0000 URL: https://git.openjdk.java.net/jcstress/commit/17f407c9f87af9be800a4d900180cb49b37f112d CODETOOLS-7902921: jcstress: Pre-warmup affinity support and thread pools ! jcstress-core/src/main/java/org/openjdk/jcstress/ForkedMain.java From shade at openjdk.java.net Wed May 5 07:33:58 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 5 May 2021 07:33:58 GMT Subject: Withdrawn: CODETOOLS-7902921: jcstress: Pre-warmup affinity support and thread pools In-Reply-To: References: Message-ID: On Wed, 5 May 2021 06:56:08 GMT, Aleksey Shipilev wrote: > Profiling for "-m sanity" runs shows that we spend considerable amount of time doing the first-use initialization of AffinitySupport in the worker threads. We can make it better by offloading that first initialization to the worker task that runs during the rest of the infra initialization. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/49 From shade at openjdk.java.net Wed May 5 09:04:13 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 5 May 2021 09:04:13 GMT Subject: RFR: CODETOOLS-7902922: jcstress: Tune up generated code once more Message-ID: There are more tune ups in generated code in sight: - reduce the use of lambdas - reduce the use of collections - avoid some unnecessary loops - avoid excessive message handling ------------- Commit messages: - Tune up generated code in jcstress infra Changes: https://git.openjdk.java.net/jcstress/pull/50/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=50&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902922 Stats: 142 lines in 4 files changed: 41 ins; 40 del; 61 mod Patch: https://git.openjdk.java.net/jcstress/pull/50.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/50/head:pull/50 PR: https://git.openjdk.java.net/jcstress/pull/50 From duke at openjdk.java.net Wed May 5 09:38:25 2021 From: duke at openjdk.java.net (duke) Date: Wed, 5 May 2021 09:38:25 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902922: jcstress: Tune up generated code once more Message-ID: Changeset: 16216104 Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-05 11:38:08 +0000 URL: https://git.openjdk.java.net/jcstress/commit/162161048df3ef4907d5bbdb9fbd5ce8c83853a8 CODETOOLS-7902922: jcstress: Tune up generated code once more ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/processors/JCStressTestProcessor.java + jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/FootprintEstimator.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/ForkedTestConfig.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/Runner.java From shade at openjdk.java.net Wed May 5 09:40:58 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 5 May 2021 09:40:58 GMT Subject: Withdrawn: CODETOOLS-7902922: jcstress: Tune up generated code once more In-Reply-To: References: Message-ID: On Wed, 5 May 2021 08:59:33 GMT, Aleksey Shipilev wrote: > There are more tune ups in generated code in sight: > - reduce the use of lambdas > - reduce the use of collections > - avoid some unnecessary loops > - avoid excessive message handling This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/50 From shade at openjdk.java.net Wed May 5 10:56:23 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 5 May 2021 10:56:23 GMT Subject: RFR: CODETOOLS-7902923: jcstress: Eliminate dependency on Executors/Futures in forked VMs Message-ID: Forked VMs are executing the tests, and they are inherently using some concurrency primitives that might be under the test. Executors/Futures are the examples of such primitives. Since the jcstress uses are simple, we might as well do the hand-rolled implementations on bare Threads. This would improve test fidelity. ------------- Commit messages: - Avoid Executors/Futures Changes: https://git.openjdk.java.net/jcstress/pull/51/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=51&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902923 Stats: 277 lines in 7 files changed: 189 ins; 47 del; 41 mod Patch: https://git.openjdk.java.net/jcstress/pull/51.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/51/head:pull/51 PR: https://git.openjdk.java.net/jcstress/pull/51 From shade at openjdk.java.net Wed May 5 11:29:57 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 5 May 2021 11:29:57 GMT Subject: Withdrawn: CODETOOLS-7902923: jcstress: Eliminate dependency on Executors/Futures in forked VMs In-Reply-To: References: Message-ID: On Wed, 5 May 2021 10:50:55 GMT, Aleksey Shipilev wrote: > Forked VMs are executing the tests, and they are inherently using some concurrency primitives that might be under the test. Executors/Futures are the examples of such primitives. Since the jcstress uses are simple, we might as well do the hand-rolled implementations on bare Threads. This would improve test fidelity. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/51 From duke at openjdk.java.net Wed May 5 11:27:31 2021 From: duke at openjdk.java.net (duke) Date: Wed, 5 May 2021 11:27:31 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902923: jcstress: Eliminate dependency on Executors/Futures in forked VMs Message-ID: <6c70fb6c-f008-4593-ad8d-940132540879@openjdk.java.net> Changeset: 2b7d411a Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-05 13:26:44 +0000 URL: https://git.openjdk.java.net/jcstress/commit/2b7d411aaf53637b83959fe422725e46773b1413 CODETOOLS-7902923: jcstress: Eliminate dependency on Executors/Futures in forked VMs ! jcstress-core/src/main/java/org/openjdk/jcstress/ForkedMain.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/processors/JCStressTestProcessor.java + jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/AbstractThread.java + jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/CounterThread.java + jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/LongThread.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/Runner.java + jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/VoidThread.java From shade at openjdk.java.net Wed May 5 12:40:22 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 5 May 2021 12:40:22 GMT Subject: RFR: CODETOOLS-7902925: jcstress: Fix new Sonar warnings Message-ID: After recent work, Sonar complains about AbstractThread. ------------- Commit messages: - Fix AbstractThread Changes: https://git.openjdk.java.net/jcstress/pull/52/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=52&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902925 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jcstress/pull/52.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/52/head:pull/52 PR: https://git.openjdk.java.net/jcstress/pull/52 From duke at openjdk.java.net Wed May 5 14:06:52 2021 From: duke at openjdk.java.net (duke) Date: Wed, 5 May 2021 14:06:52 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902925: jcstress: Fix new Sonar warnings Message-ID: <6ae5d618-6343-48b7-8e1d-6ae38c51ee36@openjdk.java.net> Changeset: f022ee13 Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-05 16:06:15 +0000 URL: https://git.openjdk.java.net/jcstress/commit/f022ee13d8d0a8916741734bbedf18d2011b7256 CODETOOLS-7902925: jcstress: Fix new Sonar warnings ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/AbstractThread.java From shade at openjdk.java.net Wed May 5 14:08:59 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Wed, 5 May 2021 14:08:59 GMT Subject: Withdrawn: CODETOOLS-7902925: jcstress: Fix new Sonar warnings In-Reply-To: References: Message-ID: On Wed, 5 May 2021 12:35:30 GMT, Aleksey Shipilev wrote: > After recent work, Sonar complains about AbstractThread. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/52 From shade at redhat.com Wed May 5 17:04:36 2021 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 5 May 2021 19:04:36 +0200 Subject: JCStress 0.11 Message-ID: <8d74758d-b673-4eca-4ac3-6a1b4709b748@redhat.com> Hi, JCStress 0.11 is released and available on Maven Central. This is useful for those who use JCStress as Maven dependency. This release further improves harness reliability and testing performance. It comes with the following improvements and bugfixes: *) Regression: interruption tests were failing after recent refactoring; and this went unnoticed in current CIs 7902917: jcstress: Errors during interruption tests *) Reliability: More Linux sysfs bugfixes, used to fail on some virtualized environments 7902919: jcstress: Sysfs topology parser fails due to oddly intersecting core IDs *) Reliability: Forked VM (the VM that actually runs tests) code now uses less java.util.concurrent to avoid potential bugs that could break the infra before the failure is detected in tests. 7902923: jcstress: Eliminate dependency on Executors/Futures in forked VMs *) Dropped features: Whitebox and online deoptimization support was removed. This is now better catered by multiple forks, which allows to capture the randomization seeds for better replication, makes the VM outputs relate to one compilation session only, etc. 7902914: jcstress: Remove Whitebox and deoptimization support *) Performance: Reworking the binary link protocol for better performance. Removing one-off Java serialization calls out of the critical path helps performance, as those path would nearly always run in interpreter, do classloads, etc. Plus, carrying less data over the link helps performance. 7902916: jcstress: Pass a limited subset of TestConfig to the forked VMs 7902918: jcstress: Replace the relevant uses of HashMultiset with Counter 7902920: jcstress: Rework binary link client/server for lower latency *) Performance: Moving some initializations out of workers helps fork startup. Avoiding the code from run-once infrastructure path helps cold startup too. 7902921: jcstress: Pre-warmup affinity support and thread pools 7902922: jcstress: Tune up generated code once more Enjoy! -- Thanks, -Aleksey From duke at openjdk.java.net Wed May 5 17:08:37 2021 From: duke at openjdk.java.net (duke) Date: Wed, 5 May 2021 17:08:37 GMT Subject: git: openjdk/jcstress: 2 new changesets Message-ID: <593abdb3-3e77-4396-a0c4-0aa12819686a@openjdk.java.net> Changeset: eb4bb76a Author: Aleksey Shipilev Date: 2021-05-05 16:44:20 +0000 URL: https://git.openjdk.java.net/jcstress/commit/eb4bb76acb93ef875d6244de46508525dd78544b JCStress v0.11. ! jcstress-benchmarks/pom.xml ! jcstress-core/pom.xml ! jcstress-java-test-archetype/pom.xml ! jcstress-result-gen/pom.xml ! jcstress-samples/pom.xml ! jcstress-test-gen/pom.xml ! pom.xml ! tests-all/pom.xml ! tests-chapter-0a/pom.xml ! tests-chapter-0b/pom.xml ! tests-chapter-0c/pom.xml ! tests-chapter-0d/pom.xml ! tests-chapter-0e/pom.xml ! tests-chapter-1a/pom.xml ! tests-chapter-1b/pom.xml ! tests-chapter-1c/pom.xml ! tests-chapter-1d/pom.xml ! tests-chapter-2a/pom.xml ! tests-chapter-2b/pom.xml ! tests-custom/pom.xml Changeset: 76edfb33 Author: Aleksey Shipilev Date: 2021-05-05 16:45:01 +0000 URL: https://git.openjdk.java.net/jcstress/commit/76edfb3399955ee79859b3346f600b0328b5f342 Continue in 0.12-SNAPSHOT ! jcstress-benchmarks/pom.xml ! jcstress-core/pom.xml ! jcstress-java-test-archetype/pom.xml ! jcstress-result-gen/pom.xml ! jcstress-samples/pom.xml ! jcstress-test-gen/pom.xml ! pom.xml ! tests-all/pom.xml ! tests-chapter-0a/pom.xml ! tests-chapter-0b/pom.xml ! tests-chapter-0c/pom.xml ! tests-chapter-0d/pom.xml ! tests-chapter-0e/pom.xml ! tests-chapter-1a/pom.xml ! tests-chapter-1b/pom.xml ! tests-chapter-1c/pom.xml ! tests-chapter-1d/pom.xml ! tests-chapter-2a/pom.xml ! tests-chapter-2b/pom.xml ! tests-custom/pom.xml From shade at openjdk.java.net Tue May 25 15:50:20 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 25 May 2021 15:50:20 GMT Subject: RFR: CODETOOLS-7902943: jcstress: Update console UX again Message-ID: We can make the console UX even better: print JVM/CPU in use counts, print sample frequencies, etc. ------------- Commit messages: - Cleanups - Print "<0.1%" where possible - More updates - More UX updates Changes: https://git.openjdk.java.net/jcstress/pull/53/files Webrev: https://webrevs.openjdk.java.net/?repo=jcstress&pr=53&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902943 Stats: 136 lines in 10 files changed: 92 ins; 8 del; 36 mod Patch: https://git.openjdk.java.net/jcstress/pull/53.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/53/head:pull/53 PR: https://git.openjdk.java.net/jcstress/pull/53 From shade at openjdk.java.net Tue May 25 15:58:27 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 25 May 2021 15:58:27 GMT Subject: RFR: CODETOOLS-7902943: jcstress: Update console UX again [v2] In-Reply-To: References: Message-ID: > We can make the console UX even better: print JVM/CPU in use counts, print sample frequencies, etc. Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision: - Fixes and refactorings - Remove excess method ------------- Changes: - all: https://git.openjdk.java.net/jcstress/pull/53/files - new: https://git.openjdk.java.net/jcstress/pull/53/files/7a94a234..2f4ce8ef Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jcstress&pr=53&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jcstress&pr=53&range=00-01 Stats: 23 lines in 3 files changed: 5 ins; 12 del; 6 mod Patch: https://git.openjdk.java.net/jcstress/pull/53.diff Fetch: git fetch https://git.openjdk.java.net/jcstress pull/53/head:pull/53 PR: https://git.openjdk.java.net/jcstress/pull/53 From duke at openjdk.java.net Tue May 25 16:58:17 2021 From: duke at openjdk.java.net (duke) Date: Tue, 25 May 2021 16:58:17 GMT Subject: git: openjdk/jcstress: CODETOOLS-7902943: jcstress: Update console UX again Message-ID: Changeset: 345f0aeb Author: Aleksey Shipil?v Committer: GitHub Date: 2021-05-25 18:57:33 +0000 URL: https://git.openjdk.java.net/jcstress/commit/345f0aeb2ae3c14bc0e72520aaab18d006be43d8 CODETOOLS-7902943: jcstress: Update console UX again ! jcstress-core/src/main/java/org/openjdk/jcstress/JCStress.java ! jcstress-core/src/main/java/org/openjdk/jcstress/TestExecutor.java ! jcstress-core/src/main/java/org/openjdk/jcstress/annotations/Expect.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/grading/ConsoleReportPrinter.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/grading/ReportUtils.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/processors/JCStressTestProcessor.java ! jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/TestList.java ! jcstress-core/src/main/java/org/openjdk/jcstress/os/Scheduler.java ! jcstress-core/src/main/java/org/openjdk/jcstress/util/StringUtils.java ! jcstress-core/src/main/java/org/openjdk/jcstress/util/TestLineWriter.java From shade at openjdk.java.net Tue May 25 21:58:14 2021 From: shade at openjdk.java.net (Aleksey Shipilev) Date: Tue, 25 May 2021 21:58:14 GMT Subject: Withdrawn: CODETOOLS-7902943: jcstress: Update console UX again In-Reply-To: References: Message-ID: On Tue, 25 May 2021 15:44:43 GMT, Aleksey Shipilev wrote: > We can make the console UX even better: print JVM/CPU in use counts, print sample frequencies, etc. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/jcstress/pull/53