RFR: ClassicProblem_02_ProducerConsumerProblem - third try [v2]

[Aleksey Shipilev]

On Thu, 18 Nov 2021 21:38:12 GMT, Michael Mirwaldt <duke at openjdk.java.net> wrote:

>> jcstress-samples/src/main/java/org/openjdk/jcstress/samples/concurrency/classic/ClassicProblem_02_ProducerConsumerProblem.java line 49:
>> 
>>> 47:  */
>>> 48: public abstract class ClassicProblem_02_ProducerConsumerProblem {
>>> 49:     private final static int BUFFER_SIZE = 2;
>> 
>> This should be inside `SemaphoresBase`?
>
> No, I don't think so because the two examples _Lock_ and _AtomicIntegers_ both use _BUFFER_SIZE_ but they are not sub classes of _SemaphoresBase_. They don't use any semaphores.

All right.

>> jcstress-samples/src/main/java/org/openjdk/jcstress/samples/concurrency/classic/ClassicProblem_02_ProducerConsumerProblem.java line 250:
>> 
>>> 248:             lock.lock();
>>> 249:             try {
>>> 250:                 while(count == 0) {
>> 
>> The style is to leave space after `while`, `if`, `for`, etc.
>
> IntelliJ always adds those spaces when I use the auto-format feature or any code completion feature. 
> I don't put them into the samples by intention. And the default code style uses theses spaces.
> 
> Have you got a code style file for me in which your favourite code style for JCStress is defined? If so, then please send it to me via email and I will use it so that you don't need to bother such stylistic issues anymore in this PR and neither in any next PR.

We are using pretty default code style. IDEA suggests to add a space correctly, use that suggestion.

-------------

PR: https://git.openjdk.java.net/jcstress/pull/104