From shade at openjdk.org Tue Dec 3 10:11:32 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 3 Dec 2024 10:11:32 GMT Subject: RFR: 7903890: jcstress: Rewrite/amend Singleton and Lazy primitives samples [v2] In-Reply-To: References: Message-ID: > It is obvious we do not have a good narrative around these, so let's add some. Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision: - Missing headers - Amendments: performance tests ------------- Changes: - all: https://git.openjdk.org/jcstress/pull/155/files - new: https://git.openjdk.org/jcstress/pull/155/files/9ff92719..07503013 Webrevs: - full: https://webrevs.openjdk.org/?repo=jcstress&pr=155&range=01 - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=155&range=00-01 Stats: 623 lines in 13 files changed: 611 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jcstress/pull/155.diff Fetch: git fetch https://git.openjdk.org/jcstress.git pull/155/head:pull/155 PR: https://git.openjdk.org/jcstress/pull/155 From duke at openjdk.org Tue Dec 3 10:21:02 2024 From: duke at openjdk.org (duke) Date: Tue, 3 Dec 2024 10:21:02 GMT Subject: git: openjdk/jcstress: 7903890: jcstress: Rewrite/amend Singleton and Lazy primitives samples Message-ID: <6b043611-8691-4af7-b8f3-e0cbb5fe5906@openjdk.org> Changeset: 7b124f6c Branch: master Author: Aleksey Shipil?v Committer: GitHub Date: 2024-12-03 11:19:56 +0000 URL: https://git.openjdk.org/jcstress/commit/7b124f6cbb2e5fc32d9146be7066aaf8ebb2fa05 7903890: jcstress: Rewrite/amend Singleton and Lazy primitives samples ! jcstress-benchmarks/pom.xml + jcstress-benchmarks/src/main/java/org/openjdk/jcstress/LazyBench.java + jcstress-benchmarks/src/main/java/org/openjdk/jcstress/SingletonBench.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/Lazy_01_BrokenFactory.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/Lazy_02_BrokenNulls.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/Lazy_03_Basic.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/Lazy_04_BrokenOneShot.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/Lazy_05_WrapperOneShot.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/Lazy_06_FencedOneShot.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/performance.md + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/shared/Holder.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/shared/HolderFactory.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/shared/Lazy.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/shared/NullHolderFactory.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/lazy/shared/SupplierDupException.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_01_BrokenUnsynchronized.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_02_BrokenVolatile.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_03_InefficientCAS.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_04_InefficientSynchronized.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_05_DCL.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_06_AcquireReleaseDCL.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_07_BrokenNonVolatileDCL.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_08_FinalWrapper.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_09_Holder.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/Singleton_10_ThreadLocalWitness.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/performance.md + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/shared/Factory.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/shared/FinalSingleton.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/shared/MapResult.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/shared/NonFinalSingleton.java + jcstress-samples/src/main/java/org/openjdk/jcstress/samples/primitives/singletons/shared/Singleton.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/FinalWrapper.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/GradingSafe.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/GradingUnsafe.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/Holder.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/SafeDCL.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/SafeLocalDCL.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/Singleton.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/SingletonSafe.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/SingletonUnsafe.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/SynchronizedCL.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/UnsafeDCL.java - tests-custom/src/main/java/org/openjdk/jcstress/tests/singletons/UnsafeLocalDCL.java From shade at openjdk.org Tue Dec 3 10:22:54 2024 From: shade at openjdk.org (Aleksey Shipilev) Date: Tue, 3 Dec 2024 10:22:54 GMT Subject: Withdrawn: 7903890: jcstress: Rewrite/amend Singleton and Lazy primitives samples In-Reply-To: References: Message-ID: On Fri, 29 Nov 2024 19:44:24 GMT, Aleksey Shipilev wrote: > It is obvious we do not have a good narrative around these, so let's add some. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jcstress/pull/155 From jvanek at openjdk.org Sat Dec 14 19:31:49 2024 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Sat, 14 Dec 2024 19:31:49 GMT Subject: RFR: 7903774: make all tests combinations printing nicer and/or configurable [v4] In-Reply-To: References: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> Message-ID: <4Y2PmkKV6aEM8YSWeZRgFeiYWp-Y-pPSz8L7TaePt_Y=.c7c0d27b-9b3e-4a81-b9ad-74149a726ba6@github.com> On Fri, 15 Nov 2024 18:45:24 GMT, Ji?? Van?k wrote: >> This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested. >> >> It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable. >> >> From: >> >> `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149 >> `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact >> `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149 >> `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910 >> `COMBINATIONS_JSON` same as combinations, but a valid json >> `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed >> >> >> * TESTS are already implemented as ALL_MATCHING >> * COMBINATIONS as ALL_MATCHING_COMBINATIONS >> * ALL_TESTS as ALL >> >> COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development. >> The _JSON variants are tobe decided, but ability to JQL it sounds nice. >> >> Suggestion to better names welcomed. > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > Fixed spacing in help I intend to finish this. Still some feedback if it is even desired, and selected approach is ok, would be nice. ------------- PR Comment: https://git.openjdk.org/jcstress/pull/153#issuecomment-2543320403 From jvanek at openjdk.org Mon Dec 23 11:52:01 2024 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 23 Dec 2024 11:52:01 GMT Subject: RFR: 7903774: make all tests combinations printing nicer and/or configurable [v5] In-Reply-To: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> References: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> Message-ID: > This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested. > > It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable. > > From: > > `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact > `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910 > `COMBINATIONS_JSON` same as combinations, but a valid json > `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed > > > * TESTS are already implemented as ALL_MATCHING > * COMBINATIONS as ALL_MATCHING_COMBINATIONS > * ALL_TESTS as ALL > > COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development. > The _JSON variants are tobe decided, but ability to JQL it sounds nice. > > Suggestion to better names welcomed. Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: Implemented totaling of listing only ------------- Changes: - all: https://git.openjdk.org/jcstress/pull/153/files - new: https://git.openjdk.org/jcstress/pull/153/files/67b737ba..5006dead Webrevs: - full: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=04 - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=03-04 Stats: 34 lines in 1 file changed: 31 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jcstress/pull/153.diff Fetch: git fetch https://git.openjdk.org/jcstress.git pull/153/head:pull/153 PR: https://git.openjdk.org/jcstress/pull/153 From jvanek at openjdk.org Mon Dec 23 13:27:23 2024 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 23 Dec 2024 13:27:23 GMT Subject: RFR: 7903774: make all tests combinations printing nicer and/or configurable [v6] In-Reply-To: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> References: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> Message-ID: > This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested. > > It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable. > > From: > > `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact > `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910 > `COMBINATIONS_JSON` same as combinations, but a valid json > `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed > > > * TESTS are already implemented as ALL_MATCHING > * COMBINATIONS as ALL_MATCHING_COMBINATIONS > * ALL_TESTS as ALL > > COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development. > The _JSON variants are tobe decided, but ability to JQL it sounds nice. > > Suggestion to better names welcomed. Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: Implemented naive json formatting ------------- Changes: - all: https://git.openjdk.org/jcstress/pull/153/files - new: https://git.openjdk.org/jcstress/pull/153/files/5006dead..0219ab93 Webrevs: - full: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=05 - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=04-05 Stats: 50 lines in 1 file changed: 42 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jcstress/pull/153.diff Fetch: git fetch https://git.openjdk.org/jcstress.git pull/153/head:pull/153 PR: https://git.openjdk.org/jcstress/pull/153 From jvanek at openjdk.org Mon Dec 23 13:48:23 2024 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 23 Dec 2024 13:48:23 GMT Subject: RFR: 7903774: make all tests combinations printing nicer and/or configurable [v7] In-Reply-To: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> References: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> Message-ID: <2vOfY1PB3IuYckn0noaABLOwRRf1B8TjXSfValiUTdU=.ea01f672-675f-442c-94ee-16cd08c444fc@github.com> > This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested. > > It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable. > > From: > > `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact > `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910 > `COMBINATIONS_JSON` same as combinations, but a valid json > `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed > > > * TESTS are already implemented as ALL_MATCHING > * COMBINATIONS as ALL_MATCHING_COMBINATIONS > * ALL_TESTS as ALL > > COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development. > The _JSON variants are tobe decided, but ability to JQL it sounds nice. > > Suggestion to better names welcomed. Ji?? Van?k has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Implemented naive json formatting To cut away the header one can use: | sed '0,/^All.*[0-9]\+$/d' ------------- Changes: - all: https://git.openjdk.org/jcstress/pull/153/files - new: https://git.openjdk.org/jcstress/pull/153/files/0219ab93..60bbb3e8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=06 - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=05-06 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jcstress/pull/153.diff Fetch: git fetch https://git.openjdk.org/jcstress.git pull/153/head:pull/153 PR: https://git.openjdk.org/jcstress/pull/153 From jvanek at openjdk.org Mon Dec 23 16:10:21 2024 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 23 Dec 2024 16:10:21 GMT Subject: RFR: 7903774: make all tests combinations printing nicer and/or configurable [v8] In-Reply-To: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> References: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> Message-ID: > This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested. > > It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable. > > From: > > `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact > `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910 > `COMBINATIONS_JSON` same as combinations, but a valid json > `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed > > > * TESTS are already implemented as ALL_MATCHING > * COMBINATIONS as ALL_MATCHING_COMBINATIONS > * ALL_TESTS as ALL > > COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development. > The _JSON variants are tobe decided, but ability to JQL it sounds nice. > > Suggestion to better names welcomed. Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: Added property to control json variants fragemnts if true, the key will be written as: "[actor1, actor2], spinLoopStyle: Thread.onSpinWait(), threads: 2, forkId: 0, maxFootprintMB: 64, compileMode: 7, shClass: (PG 0, CG 0), (PG 0, CG 0), strideSize: 256, strideCount: 40, cpuMap: null, [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]" otherwise (default), it will be written as ... "actorNames": ["actor1", "actor2"], "spinLoopStyle": "Thread.onSpinWait()", "threads": 2, "forkId": 0, "maxFootprintMB": 64, "compileMode": 7, "shClass": "(PG 0, CG 0), (PG 0, CG 0)", "strideSize": 256, "strideCount": 40, "cpuMap": "null", "jvmArgs": [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]" ... ------------- Changes: - all: https://git.openjdk.org/jcstress/pull/153/files - new: https://git.openjdk.org/jcstress/pull/153/files/60bbb3e8..12cad1b8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=07 - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=06-07 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jcstress/pull/153.diff Fetch: git fetch https://git.openjdk.org/jcstress.git pull/153/head:pull/153 PR: https://git.openjdk.org/jcstress/pull/153 From jvanek at openjdk.org Mon Dec 30 16:54:02 2024 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 30 Dec 2024 16:54:02 GMT Subject: RFR: 7903774: make all tests combinations printing nicer and/or configurable [v8] In-Reply-To: References: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> Message-ID: On Mon, 23 Dec 2024 16:10:21 GMT, Ji?? Van?k wrote: >> This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested. >> >> It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable. >> >> From: >> >> `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149 >> `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact >> `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149 >> `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910 >> `COMBINATIONS_JSON` same as combinations, but a valid json >> `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed >> >> >> * TESTS are already implemented as ALL_MATCHING >> * COMBINATIONS as ALL_MATCHING_COMBINATIONS >> * ALL_TESTS as ALL >> >> COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development. >> The _JSON variants are tobe decided, but ability to JQL it sounds nice. >> >> Suggestion to better names welcomed. > > Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision: > > Added property to control json variants fragemnts > > if true, the key will be written as: > "[actor1, actor2], spinLoopStyle: Thread.onSpinWait(), threads: 2, forkId: 0, maxFootprintMB: 64, compileMode: 7, shClass: (PG 0, CG 0), (PG 0, CG 0), strideSize: 256, strideCount: 40, cpuMap: null, [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]" > > otherwise (default), it will be written as > > ... > "actorNames": ["actor1", "actor2"], > "spinLoopStyle": "Thread.onSpinWait()", > "threads": 2, > "forkId": 0, > "maxFootprintMB": 64, > "compileMode": 7, > "shClass": "(PG 0, CG 0), (PG 0, CG 0)", > "strideSize": 256, > "strideCount": 40, > "cpuMap": "null", > "jvmArgs": [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]" > ... hi @shipilev ! This is now feature complete for https://github.com/openjdk/jcstress/pull/149#discussion_r1668900808 what do you think? ------------- PR Comment: https://git.openjdk.org/jcstress/pull/153#issuecomment-2565709353 From jvanek at openjdk.org Mon Dec 30 16:54:02 2024 From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=) Date: Mon, 30 Dec 2024 16:54:02 GMT Subject: RFR: 7903774: make all tests combinations printing nicer and/or configurable [v9] In-Reply-To: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> References: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com> Message-ID: > This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested. > > It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable. > > From: > > `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact > `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149 > `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910 > `COMBINATIONS_JSON` same as combinations, but a valid json > `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed > > > * TESTS are already implemented as ALL_MATCHING > * COMBINATIONS as ALL_MATCHING_COMBINATIONS > * ALL_TESTS as ALL > > COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development. > The _JSON variants are tobe decided, but ability to JQL it sounds nice. > > Suggestion to better names welcomed. Ji?? Van?k has updated the pull request incrementally with two additional commits since the last revision: - Implemented proper json listings - id can be used both flatten (so equal to plaintext) or properly strcutured for JQ (default) - listing can be redirecd to stderr to use with `jq` directly - ALL now corectly return all tests ------------- Changes: - all: https://git.openjdk.org/jcstress/pull/153/files - new: https://git.openjdk.org/jcstress/pull/153/files/12cad1b8..b8d0209d Webrevs: - full: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=08 - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=153&range=07-08 Stats: 196 lines in 4 files changed: 133 ins; 3 del; 60 mod Patch: https://git.openjdk.org/jcstress/pull/153.diff Fetch: git fetch https://git.openjdk.org/jcstress.git pull/153/head:pull/153 PR: https://git.openjdk.org/jcstress/pull/153