RFR: 7903774: make all tests combinations printing nicer and/or configurable [v8]

Jiří Vaněk jvanek at openjdk.org
Mon Dec 30 16:54:02 UTC 2024


On Mon, 23 Dec 2024 16:10:21 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested.
>> 
>> It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable.
>> 
>> From:
>> 
>> `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149
>> `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact
>> `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149
>> `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910
>> `COMBINATIONS_JSON` same as combinations, but a valid json
>> `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed 
>> 
>> 
>> * TESTS are already implemented as ALL_MATCHING
>> * COMBINATIONS as ALL_MATCHING_COMBINATIONS
>> * ALL_TESTS as ALL
>> 
>> COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development.
>> The _JSON variants are tobe decided, but ability to JQL it sounds nice.
>> 
>> Suggestion to better names welcomed.
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added property to control json variants fragemnts
>   
>   if true, the key will be written as:
>   "[actor1, actor2], spinLoopStyle: Thread.onSpinWait(), threads: 2, forkId: 0, maxFootprintMB: 64, compileMode: 7, shClass: (PG 0, CG 0), (PG 0, CG 0), strideSize: 256, strideCount: 40, cpuMap: null, [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]"
>   
>   otherwise (default), it will be written as
>   
>   ...
>   "actorNames": ["actor1", "actor2"],
>   "spinLoopStyle": "Thread.onSpinWait()",
>   "threads": 2,
>   "forkId": 0,
>   "maxFootprintMB": 64,
>   "compileMode": 7,
>   "shClass": "(PG 0, CG 0), (PG 0, CG 0)",
>   "strideSize": 256,
>   "strideCount": 40,
>   "cpuMap": "null",
>   "jvmArgs": [-XX:+UseBiasedLocking, -XX:+StressLCM, -XX:+StressGCM, -XX:+StressIGVN, -XX:+StressCCP, -XX:StressSeed=yyyyyyyy]"
>   ...

hi @shipilev  ! This is now feature complete for https://github.com/openjdk/jcstress/pull/149#discussion_r1668900808  what do you think?

-------------

PR Comment: https://git.openjdk.org/jcstress/pull/153#issuecomment-2565709353


More information about the jcstress-dev mailing list