RFR: CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings [v2]

Jiří Vaněk jvanek at openjdk.org
Wed Jul 3 08:25:45 UTC 2024


On Tue, 2 Jul 2024 17:10:27 GMT, PM <duke at openjdk.org> wrote:

>> Jiří Vaněk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings
>>   
>>   This is extracting  List<TestConfig> configs =prepareRunProgram(classes, tests);
>>   with all he HW/switches setup to separated method and reusing it in `-l` mode
>>   
>>   -l now honours also verbose mode, in which it prints not just matching
>>   tests but all really run tests, and thus enabling much more easy
>>   determining of all tests
>>   
>>   help adjusted.
>>   
>>   Maybe I'm missing plain quick initial all tests metod now, but with
>>   artificial -c MAX it seems doing exactly that
>
> jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/TestConfig.java line 39:
> 
>> 37: import java.io.Serializable;
>> 38: import java.util.List;
>> 39: import java.util.stream.Collectors;
> 
> import is not required

fixed

> jcstress-core/src/main/java/org/openjdk/jcstress/infra/runners/TestConfig.java line 265:
> 
>> 263:                 ", strideCount=" + strideCount +
>> 264:                 ", cpuMap=" + cpuMap +
>> 265:                 ", " + jvmArgs + "}";
> 
> kindly modify it to return the json based structure, as followed in rest of the class, equals symbol does not appear in json

fixed

-------------

PR Review Comment: https://git.openjdk.org/jcstress/pull/149#discussion_r1663759436
PR Review Comment: https://git.openjdk.org/jcstress/pull/149#discussion_r1663759712


More information about the jcstress-dev mailing list