RFR: CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings [v3]

Jiří Vaněk jvanek at openjdk.org
Wed Jul 3 08:33:44 UTC 2024


On Wed, 3 Jul 2024 08:25:44 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> This is extracting  List<TestConfig> configs =prepareRunProgram(classes, tests);
>> with all he HW/switches setup to separated method and reusing it in `-l` mode
>> 
>> I'm aware of triplicated removal of -agentlib, and will clean it up as
>> CODETOOLS-7903756 will progress.
>> 
>> -l now honours also verbose mode, in which it prints not just matching
>> tests but all really run tests, and thus enabling much more easy
>> determining of all tests
>> 
>> help adjusted.
>> 
>> Maybe I'm missing plain quick initial all tests metod now, but with 
>> artificial -c MAX it seems doing exactly that
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replaced = by : in toDetailedTest method of TestConfig
>   
>   in meantime dropped redundant import

hi! Thanx a lot for review! I did as you bif, although I would prefer to keep LIST_OPTION_DESCRIPTION as it was - on two lines.  Whether to use it in parser.accepts method or not, to have it outside is much better, but then it should be done globalluy. NVM:)  Thanx again!

-------------

PR Comment: https://git.openjdk.org/jcstress/pull/149#issuecomment-2205411898


More information about the jcstress-dev mailing list