RFR: CODETOOLS-7903756 - jcstress shuld not pass debugging parameters to subproceses [v3]

[PM]

On Wed, 3 Jul 2024 08:56:57 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> No longer passing any -agentlib to subprocesses, unless it is part of -jvmArgsPrepend, thus allowing to debug both jcstress itself or wrked vm as expected:
>> 
>> java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5005  -jar tests-all/target/jcstress.jar -c 1 -jvmArgsPrepend "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5006"
>> 
>> works.
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved removeJdwpAgentLib from Options to VMSupport

other than the imports it looks good to me

jcstress-core/src/main/java/org/openjdk/jcstress/Options.java line 43:

> 41: import java.util.*;
> 42: import java.util.concurrent.TimeUnit;
> 43: import java.util.stream.Collectors;

this import is not required now

jcstress-core/src/main/java/org/openjdk/jcstress/TestExecutor.java line 41:

> 39: import java.util.concurrent.*;
> 40: import java.util.concurrent.atomic.AtomicInteger;
> 41: import java.util.stream.Collectors;

same here as well

-------------

Changes requested by matcdac at github.com (no known OpenJDK username).

PR Review: https://git.openjdk.org/jcstress/pull/150#pullrequestreview-2157226428
PR Review Comment: https://git.openjdk.org/jcstress/pull/150#discussion_r1664663158
PR Review Comment: https://git.openjdk.org/jcstress/pull/150#discussion_r1664663889