RFR: CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings [v4]
PM
duke at openjdk.org
Thu Jul 4 08:21:36 UTC 2024
On Thu, 4 Jul 2024 08:07:24 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
>> ok sure, gotcha, the human readable output with `-v` option what you are printing right now should be fine, just one small change I would request, instead of doing string concatenation with the `+` operator, can we use append operation with String Builder or String Buffer whichever is more appropriate here
>
> Thanx, done!
> Maybe.. can I return back the "=" instead of ": " ?
I'd suggest to probably let it be, because the name is there at the start following the convention of other tests in the `else` clause where just the name is printed. Here in the `if` clause we have the additional content wrapped in `{ }` , although its partial json, it can still be modified to complete json with less changes in future if required
-------------
PR Review Comment: https://git.openjdk.org/jcstress/pull/149#discussion_r1665321229
More information about the jcstress-dev
mailing list