RFR: 7903756: jcstress: Skip debugging JVM options for sub-processes [v4]

[Aleksey Shipilev]

On Thu, 4 Jul 2024 06:25:05 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> No longer passing any -agentlib to subprocesses, unless it is part of -jvmArgsPrepend, thus allowing to debug both jcstress itself or wrked vm as expected:
>> 
>> java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5005  -jar tests-all/target/jcstress.jar -c 1 -jvmArgsPrepend "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5006"
>> 
>> works.
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unused imports

This looks okay, but I would probably just inline `removeJdwpAgentLib` into `cleanArgs` and re-indent the stream as the code around does it (ops on different lines, collect as the last line). The single-line helper method does not carry its weight, IMO.

Wait, let's make sure it passes the GHA tests, enable the workflows first, and then update the PR.

jcstress-core/src/main/java/org/openjdk/jcstress/vm/VMSupport.java line 402:

> 400:     }
> 401: 
> 402:     private static List<String> removeJdwpAgentLib(List<String> originalArgs ) {

Suggestion:

    private static List<String> removeJdwpAgentLib(List<String> originalArgs) {

-------------

Marked as reviewed by shade (Committer).

PR Review: https://git.openjdk.org/jcstress/pull/150#pullrequestreview-2162921510
Changes requested by shade (Committer).

PR Review: https://git.openjdk.org/jcstress/pull/150#pullrequestreview-2162925918
PR Review Comment: https://git.openjdk.org/jcstress/pull/150#discussion_r1668397200