RFR: CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings [v10]

[Aleksey Shipilev]

On Mon, 8 Jul 2024 15:05:22 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> This is extracting  List<TestConfig> configs =prepareRunProgram(classes, tests);
>> with all he HW/switches setup to separated method and reusing it in `-l` mode
>> 
>> I'm aware of triplicated removal of -agentlib, and will clean it up as
>> CODETOOLS-7903756 will progress.
>> 
>> -l now honours also verbose mode, in which it prints not just matching
>> tests but all really run tests, and thus enabling much more easy
>> determining of all tests
>> 
>> help adjusted.
>> 
>> Maybe I'm missing plain quick initial all tests metod now, but with 
>> artificial -c MAX it seems doing exactly that
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Enabled GHA

More nits.

jcstress-core/src/main/java/org/openjdk/jcstress/JCStress.java line 87:

> 85:         parseResults();
> 86:     }
> 87:     private ConfigsWithScheduler getConfigs() {

Suggestion:

    }

    private ConfigsWithScheduler getConfigs() {

jcstress-core/src/main/java/org/openjdk/jcstress/JCStress.java line 229:

> 227:    }
> 228: 
> 229:     public int listTests(Options opts, JCStress jcstress) {

You don't need to pass `JCStress jcstress` now that the method is instance one.

-------------

PR Review: https://git.openjdk.org/jcstress/pull/149#pullrequestreview-2163739640
PR Review Comment: https://git.openjdk.org/jcstress/pull/149#discussion_r1668901395
PR Review Comment: https://git.openjdk.org/jcstress/pull/149#discussion_r1668889997