From jvanek at openjdk.org  Sat Feb  1 17:30:57 2025
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Sat, 1 Feb 2025 17:30:57 GMT
Subject: RFR: 7903889: jcstress: document used properites (and env
 variables) [v5]
In-Reply-To: <H-dXCLsSQrSosPPDWsPrI9VJME2Htlkyys-yoWdr5dI=.f7c55c59-310e-43f0-956c-fa112ee81ff7@github.com>
References: <_id_iOGQYGai8cFr-oaXer0R8UivNlj7-ZavmtRzetU=.1c07c8af-058d-4a9e-b83b-3a23bfb68776@github.com>
 <H-dXCLsSQrSosPPDWsPrI9VJME2Htlkyys-yoWdr5dI=.f7c55c59-310e-43f0-956c-fa112ee81ff7@github.com>
Message-ID: <NBmOeV0oP66hcurWVi7uxg6nbhFuc8vtJDAeoIFzJ1U=.48e8cb19-a3e2-4d00-8755-7bbd98b83757@github.com>

On Sat, 25 Jan 2025 12:27:14 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> The purpose of this PR is to move properties and properties based initializations to single place, and to document them, and to enable printing the listing with the documentation via help.
>> 
>> No Env. vars were found.
>> 
>> The verbose help can be removed, the individual properties with defaults are wrapped to its class. The OptionSpec and OptionFormatter can be used if needed
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Moved declaration of individual proeprties to ceparate classes by family

...keep live...

-------------

PR Comment: https://git.openjdk.org/jcstress/pull/156#issuecomment-2629037882

From jvanek at openjdk.org  Sat Feb  1 17:31:57 2025
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Sat, 1 Feb 2025 17:31:57 GMT
Subject: RFR: 7903774: make all tests combinations printing nicer and/or
 configurable [v9]
In-Reply-To: <gAawgvECTPTF2k2zzFpoT8WN8Ja1W1pmeL6NikGrgEs=.79213a30-4bd8-4361-9bfd-565c863b6388@github.com>
References: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com>
 <gAawgvECTPTF2k2zzFpoT8WN8Ja1W1pmeL6NikGrgEs=.79213a30-4bd8-4361-9bfd-565c863b6388@github.com>
Message-ID: <DXW0ezU7Vso-tX7hepyrc3cgxeoqAV3GkDkrgwp6BV4=.4a74c97d-3a3a-4f39-a72e-1741e47b6a3f@github.com>

On Mon, 30 Dec 2024 16:54:02 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested.
>> 
>> It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable.
>> 
>> From:
>> 
>> `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149
>> `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact
>> `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149
>> `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910
>> `COMBINATIONS_JSON` same as combinations, but a valid json
>> `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed 
>> 
>> 
>> * TESTS are already implemented as ALL_MATCHING
>> * COMBINATIONS as ALL_MATCHING_COMBINATIONS
>> * ALL_TESTS as ALL
>> 
>> COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development.
>> The _JSON variants are tobe decided, but ability to JQL it sounds nice.
>> 
>> Suggestion to better names welcomed.
>
> Ji?? Van?k has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Implemented proper json listings
>    
>    - id can be used both flatten (so equal to plaintext) or properly
>    strcutured for JQ (default)
>    - listing can be redirecd to stderr to use with `jq` directly
>  - ALL now corectly return all tests

...keep live...

-------------

PR Comment: https://git.openjdk.org/jcstress/pull/153#issuecomment-2629038264

From jvanek at openjdk.org  Mon Feb  3 12:30:05 2025
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Mon, 3 Feb 2025 12:30:05 GMT
Subject: RFR: 7903774: make all tests combinations printing nicer and/or
 configurable [v9]
In-Reply-To: <gAawgvECTPTF2k2zzFpoT8WN8Ja1W1pmeL6NikGrgEs=.79213a30-4bd8-4361-9bfd-565c863b6388@github.com>
References: <3wZeI91CX_iFefOZJdSxdmZFSyzjd8-w1PJXYufNxrM=.77abf5c8-c5ca-45b9-9b8b-e5c0a7e9b478@github.com>
 <gAawgvECTPTF2k2zzFpoT8WN8Ja1W1pmeL6NikGrgEs=.79213a30-4bd8-4361-9bfd-565c863b6388@github.com>
Message-ID: <wvwnW468lqu4gzU8ho2iBZVb3Rf_cJQLFZmD74Vzu2k=.cd70f5a6-64ad-42f9-a8b6-e26697d08d19@github.com>

On Mon, 30 Dec 2024 16:54:02 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> This is still WIP, but already on row what [CODETOOLS-7903774](https://bugs.openjdk.org/browse/CODETOOLS-7903774) suggested.
>> 
>> It will be finished once all desired output combinations are included, but already now is doing the usage of listing much more comfortable and code readable.
>> 
>> From:
>> 
>> `TESTS` - as introduced by https://github.com/openjdk/jcstress/pull/149
>> `COMBINATIONS` - as introduced in https://github.com/openjdk/jcstress/pull/149 verbose mode (thus surpassing the `-v` impact
>> `ALL_TESTS` - all tests as it was before https://github.com/openjdk/jcstress/pull/149
>> `COMBINATIONS_GROUPED ` - as suggested in https://github.com/openjdk/jcstress/pull/149#discussion_r1668678910
>> `COMBINATIONS_JSON` same as combinations, but a valid json
>> `COMBINATIONS_GROUPS` same as COMBINATIONS_GROUPED only instead of enumeration in each group, only count of members will be printed 
>> 
>> 
>> * TESTS are already implemented as ALL_MATCHING
>> * COMBINATIONS as ALL_MATCHING_COMBINATIONS
>> * ALL_TESTS as ALL
>> 
>> COMBINATIONS_GROUPED, and COMBINATIONS_GROUPS are under development.
>> The _JSON variants are tobe decided, but ability to JQL it sounds nice.
>> 
>> Suggestion to better names welcomed.
>
> Ji?? Van?k has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Implemented proper json listings
>    
>    - id can be used both flatten (so equal to plaintext) or properly
>    strcutured for JQ (default)
>    - listing can be redirecd to stderr to use with `jq` directly
>  - ALL now corectly return all tests

Just small recap, why this  is done - I wanted to split full load of jcstresses, into several  HWs. At least 50, so it can finish in reasonable time. This splitting is done by groups - eg https://github.com/adoptium/aqa-tests/blob/master/system/jcstress/playlist.xml#L1128  - to have those groups equally split, information provided by this PR have to be reasonably accessible.

-------------

PR Comment: https://git.openjdk.org/jcstress/pull/153#issuecomment-2630809733

From jvanek at openjdk.org  Mon Feb  3 12:36:01 2025
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Mon, 3 Feb 2025 12:36:01 GMT
Subject: RFR: 7903754: jcstress should die asap - with report - on broken
 jvm/hw, instead of waiting on kill [v2]
In-Reply-To: <gC59XqWu76J0e5JpM9DtTjATPCrOHxn9ICYuG1vddfE=.b0377e6c-e26f-49c0-b9b7-e3170cb60a55@github.com>
References: <YXTGh5WwXYP31kLN1WM5AYuPb5xoKOpoCjI0TFZ4diQ=.25589405-3afa-47a8-947e-4c70e3f14fde@github.com>
 <gC59XqWu76J0e5JpM9DtTjATPCrOHxn9ICYuG1vddfE=.b0377e6c-e26f-49c0-b9b7-e3170cb60a55@github.com>
Message-ID: <hvDimyCoDS4Nx0mj2GbccNh-0S5Qk9tJaaalQtAC7H4=.7625e7ab-c025-4562-ba67-0c63d24f9ede@github.com>

On Tue, 7 Jan 2025 15:32:10 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> Initial PoC
>> 
>> It currently show how to set up argument, and how the framework will be terminated. Feedback welcomed.  Should be finished soon
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix in logic

jcstress-core/src/main/java/org/openjdk/jcstress/infra/grading/FailFastKiller.java line 133:

> 131: 
> 132:     private void verifyState(TestResult r) {
> 133:         long totalFailed = failed + hardErrors;

Maybe the `softErrors`should be counted in? Maybe configurable by some property? wdyt?

-------------

PR Review Comment: https://git.openjdk.org/jcstress/pull/157#discussion_r1939303630

From jvanek at openjdk.org  Mon Feb  3 12:42:37 2025
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Mon, 3 Feb 2025 12:42:37 GMT
Subject: RFR: 7903754: jcstress should die asap - with report - on broken
 jvm/hw, instead of waiting on kill [v3]
In-Reply-To: <YXTGh5WwXYP31kLN1WM5AYuPb5xoKOpoCjI0TFZ4diQ=.25589405-3afa-47a8-947e-4c70e3f14fde@github.com>
References: <YXTGh5WwXYP31kLN1WM5AYuPb5xoKOpoCjI0TFZ4diQ=.25589405-3afa-47a8-947e-4c70e3f14fde@github.com>
Message-ID: <xAzxdrVwVZQHWnSudzis2ek09tFRlHO_uEPfqcvmIaM=.3549dfa9-9666-4355-b5ff-609cda820dc2@github.com>

> Initial PoC
> 
> It currently show how to set up argument, and how the framework will be terminated. Feedback welcomed.  Should be finished soon

Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:

  Experimental counting of softErrors through property

-------------

Changes:
  - all: https://git.openjdk.org/jcstress/pull/157/files
  - new: https://git.openjdk.org/jcstress/pull/157/files/fae6ff11..eeaa08e0

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jcstress&pr=157&range=02
 - incr: https://webrevs.openjdk.org/?repo=jcstress&pr=157&range=01-02

  Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jcstress/pull/157.diff
  Fetch: git fetch https://git.openjdk.org/jcstress.git pull/157/head:pull/157

PR: https://git.openjdk.org/jcstress/pull/157

From jvanek at openjdk.org  Tue Feb 25 16:54:09 2025
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 25 Feb 2025 16:54:09 GMT
Subject: RFR: 7903819: jcstress do not print structuralised results
In-Reply-To: <IUgbbJHyAWPYwqSmseeNKscyUtXdVSUpXQESdL-TRIw=.f1a12b3c-9ff7-4d28-86ce-75de4bb01c30@github.com>
References: <IUgbbJHyAWPYwqSmseeNKscyUtXdVSUpXQESdL-TRIw=.f1a12b3c-9ff7-4d28-86ce-75de4bb01c30@github.com>
Message-ID: <BlP2U77hTXqe0dn44Kfd8Xo3v_lu6dPt_DL67-b8HHk=.c158055f-fe42-4325-96f9-59121b9c98b0@github.com>

On Fri, 10 Jan 2025 15:46:48 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> Jcstress are generating very good html report, which is however not exactly great for automated comapriosns over various systyems and architectures. This pr is adding junit-like, configurable report.

More is coming! Warning for to long overtime and jdk detection and adoption to jdk23....

-------------

PR Comment: https://git.openjdk.org/jcstress/pull/158#issuecomment-2682644263

From jvanek at openjdk.org  Wed Feb 26 17:54:59 2025
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 26 Feb 2025 17:54:59 GMT
Subject: RFR: 7903671: jcstress: Update buffer tests for JDK-8318966
Message-ID: <t9Uz4xkYl2aeoYzWd61sqxNG7b9ADpv4tnEotznqDWY=.392bc5a6-4349-40c3-96bb-5ee5c56f7cfc@github.com>

part 1:  Detecting jdk of target VM and exuding illegible tests

This is prequel to full fixing of CODETOOLS-7903671. This PR detects target JDK version and then disables illegible tests.
part 2 will be done in templates of affected tests and logic around generating the classes from them. In meantime this should server.

The jdk detection will be most likely used anyway. WDYT? If we agree on similar approach, I will create a new bug for this PR only.

-------------

Commit messages:
 - Excluding jdk23+ illegible tests on jdk23+
 - Added  detection on target JDK version

Changes: https://git.openjdk.org/jcstress/pull/159/files
  Webrev: https://webrevs.openjdk.org/?repo=jcstress&pr=159&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903671
  Stats: 129 lines in 3 files changed: 121 ins; 1 del; 7 mod
  Patch: https://git.openjdk.org/jcstress/pull/159.diff
  Fetch: git fetch https://git.openjdk.org/jcstress.git pull/159/head:pull/159

PR: https://git.openjdk.org/jcstress/pull/159

From jvanek at openjdk.org  Wed Feb 26 19:34:40 2025
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 26 Feb 2025 19:34:40 GMT
Subject: RFR: 7903671: jcstress: Update buffer tests for JDK-8318966
Message-ID: <3-J81IPLLmXlshEicXdBfnLwkMofpNObYWf4qwJcapI=.f0b924f0-fec6-44d1-b4ff-5fbe13f69be9@github.com>

This is another possible fix for  https://bugs.openjdk.org/browse/CODETOOLS-7903671 - : jcstress: Update buffer tests for JDK-8318966 (Bug - P4)
This one is attempting  Experimental reduction of (0, 8) -> (0, 1) in all affected calls. Brief experiments seesm the change works. But whether it is still testing what it should.. I try to decrypt it, but up to now now proof.

I have not yet tested all affected tests. That is in progress.

-------------

Commit messages:
 - Experimental reduction 0, 8 -> 0, 1

Changes: https://git.openjdk.org/jcstress/pull/160/files
  Webrev: https://webrevs.openjdk.org/?repo=jcstress&pr=160&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903671
  Stats: 21 lines in 21 files changed: 0 ins; 0 del; 21 mod
  Patch: https://git.openjdk.org/jcstress/pull/160.diff
  Fetch: git fetch https://git.openjdk.org/jcstress.git pull/160/head:pull/160

PR: https://git.openjdk.org/jcstress/pull/160

From jvanek at openjdk.org  Wed Feb 26 19:34:41 2025
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 26 Feb 2025 19:34:41 GMT
Subject: RFR: 7903671: jcstress: Update buffer tests for JDK-8318966
In-Reply-To: <3-J81IPLLmXlshEicXdBfnLwkMofpNObYWf4qwJcapI=.f0b924f0-fec6-44d1-b4ff-5fbe13f69be9@github.com>
References: <3-J81IPLLmXlshEicXdBfnLwkMofpNObYWf4qwJcapI=.f0b924f0-fec6-44d1-b4ff-5fbe13f69be9@github.com>
Message-ID: <pmeVb5IRnh7QNeZuwqTXn3cXzM8TiTpYo4MVbhJkDds=.6946be26-e488-4a16-a21d-076ff2a6636b@github.com>

On Wed, 26 Feb 2025 19:27:27 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> This is another possible fix for  https://bugs.openjdk.org/browse/CODETOOLS-7903671 - : jcstress: Update buffer tests for JDK-8318966 (Bug - P4)
> This one is attempting  Experimental reduction of (0, 8) -> (0, 1) in all affected calls. Brief experiments seesm the change works. But whether it is still testing what it should.. I try to decrypt it, but up to now now proof.
> 
> I have not yet tested all affected tests. That is in progress.

Ah... not fulfilling its promises....
With jdk21 it was passing ok. But on 23  it got occasionally

    Check test failed
    java.lang.IllegalStateException: Atomic access not supported for heap buffer

But about half passed. I guess Ihad picked up wrong subset for initial testing

Reopening for a while... maye somebody around will know why.

-------------

PR Comment: https://git.openjdk.org/jcstress/pull/160#issuecomment-2685998642
PR Comment: https://git.openjdk.org/jcstress/pull/160#issuecomment-2686003475