RFR: 7903671: jcstress: Update buffer tests for JDK-8318966
Jiří Vaněk
jvanek at openjdk.org
Fri Jun 6 15:28:07 UTC 2025
On Wed, 26 Feb 2025 17:50:28 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
> part 1: Detecting jdk of target VM and exuding illegible tests
>
> This is prequel to full fixing of CODETOOLS-7903671. This PR detects target JDK version and then disables illegible tests.
> part 2 will be done in templates of affected tests and logic around generating the classes from them. In meantime this should server.
>
> The jdk detection will be most likely used anyway. WDYT? If we agree on similar approach, I will create a new bug for this PR only.
hi! Thanx a lot for eyball!
If this should be the way, that I would rather run it with `alignment 1` then stay with error. The error seem redundant here. JCStress is doing a lot of checks, and the final runs are based on this. Checking the java version or ByteBuffer impl seems more reasonable.. However as far as I can tell, the `alignment 1` is not triggering the parts it was with 8 and thus not testing what it should.
Sorry to say that, but I have doubts that the ByteBuffer tests are handled as soft errors. If that would be the case I think I would not bother with PR. "api mismatch" would be good enough. But as you know much better, I will try and elaborate. If they are not returning `api mismatch`, then I will elaborate in this PR so they start to return `api mismatch`.
-------------
PR Comment: https://git.openjdk.org/jcstress/pull/159#issuecomment-2949603340
More information about the jcstress-dev
mailing list