RFR: 7903750: TimeBudget (-tb) does not fulfill its promisses [v3]

[Jiří Vaněk]

On Fri, 21 Mar 2025 10:30:46 GMT, Galder Zamarreño <galder at openjdk.org> wrote:

>> Jiří Vaněk has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Used  WARNING: and FATAL: instead of +++ WARNING - and +++ FATAL -
>>  - renamed getNiceMsTimeDate to formatMsToDaysAndTime
>
> jcstress-core/src/main/java/org/openjdk/jcstress/TimeBudget.java line 156:
> 
>> 154:         }
>> 155:         if (expectedPerTest * 2 < budget.milliseconds() * 2l) {
>> 156:             System.out.println(" + +++ WARNING - your time budget will not be used. Tests will end much sooner.");
> 
> See how other warning messages are printed. You should follow similar format e.g.
> 
> 
> System.out.println("WARNING: Allocation profiling is not available: " + e.getMessage());

true. I had adjusted it so it is `+ WARNING: ...` nad same for `FATAL`:

 + FATAL: - your tests will never finish as expected. They will run much longer 
 | For 169716 with concurrency factor of 1 You have requested/been given time budget of: 01:00:00
 | That is ~21 ms per test
 + +++ However the real time will be converging to: 5d+21:25:48 +++
 | You can play with internal properties name(value/eta):
 |   jcstress.timeBudget.defaultPerTestMs(3000ms/5d+21:25:48)
 |   jcstress.timeBudget.minTimeMs(30ms/01:24:51)
 |   jcstress.timeBudget.maxTimeMs(60000ms/117d+20:36:00)
 | Which are setting up the exact times the individual tests are trying to converage to.
 + Use with caution! Test run below 100ms is moreover jeopardize the purpose. And will not squeeze the time as you wish.


I had kept the leading `+` so it continue to look aligned and is clea where it starts and ends.  If you wish me to remove also leading `+ ` then a slightly different approach would need to be taken.

-------------

PR Review Comment: https://git.openjdk.org/jcstress/pull/161#discussion_r2007524410