RFR: 7903750: TimeBudget (-tb) does not fulfill its promisses [v5]

Galder Zamarreño galder at openjdk.org
Mon Mar 24 18:08:23 UTC 2025


On Fri, 21 Mar 2025 13:07:38 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> Added warning, when time budget is to small, and final run will run at least two times longer.
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unnecesasary NPE check in getTimeBudget
>   
>   The NPE workaround was causing NPE to be only delayed for later

Just a small comment

jcstress-core/src/main/java/org/openjdk/jcstress/JCStress.java line 90:

> 88:     private TimeBudget getTimeBudget(ConfigsWithScheduler config) {
> 89:         TimeBudget timeBudget = new TimeBudget(config.configs.size(), opts.timeBudget());
> 90:         return timeBudget;

Suggestion:

        return new TimeBudget(config.configs.size(), opts.timeBudget());

-------------

Changes requested by galder (no project role).

PR Review: https://git.openjdk.org/jcstress/pull/161#pullrequestreview-2711285299
PR Review Comment: https://git.openjdk.org/jcstress/pull/161#discussion_r2010687475


More information about the jcstress-dev mailing list