<div dir="ltr">Hello Team,<div><br></div><div>Provided review comments for both <b><u>openjdk/jcstress</u> PRs : #149 </b>and<b> #150</b></div><div><br></div><div><a href="https://github.com/openjdk/jcstress/pull/149">https://github.com/openjdk/jcstress/pull/149</a><br></div><div><a href="https://github.com/openjdk/jcstress/pull/150">https://github.com/openjdk/jcstress/pull/150</a><br></div><div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><br></div>Regards,<div><b>Prakhar Makhija</b></div><div><br></div><div>+91 78294 00970<br></div><div><a href="mailto:matcdac@gmail.com" target="_blank">matcdac@gmail.com</a></div><div><a href="https://www.linkedin.com/in/prakhar-makhija-17794b107/" target="_blank">https://www.linkedin.com/in/prakhar-makhija-17794b107/</a><br></div><div><br></div></div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jul 2, 2024 at 4:13 PM <<a href="mailto:jcstress-dev-request@openjdk.org">jcstress-dev-request@openjdk.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Send jcstress-dev mailing list submissions to<br>
<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="https://mail.openjdk.org/mailman/listinfo/jcstress-dev" rel="noreferrer" target="_blank">https://mail.openjdk.org/mailman/listinfo/jcstress-dev</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:jcstress-dev-request@openjdk.org" target="_blank">jcstress-dev-request@openjdk.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:jcstress-dev-owner@openjdk.org" target="_blank">jcstress-dev-owner@openjdk.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of jcstress-dev digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings (Ji?? Van?k)<br>
2. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings [v2] (Ji?? Van?k)<br>
3. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings (Ji?? Van?k)<br>
4. RFR: CODETOOLS-7903756 - jcstress shuld not pass debugging<br>
parameters to subproceses (Ji?? Van?k)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Wed, 19 Jun 2024 13:03:31 GMT<br>
From: Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>><br>
To: <<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a>><br>
Subject: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings<br>
Message-ID:<br>
<tsWR1P-0JoBFGek8MbzKehzzm65t3BYK7LYzLMhfn58=.<a href="mailto:53203e9e-f223-4a4c-a406-ee53a14149b6@github.com" target="_blank">53203e9e-f223-4a4c-a406-ee53a14149b6@github.com</a>><br>
<br>
Content-Type: text/plain; charset=utf-8<br>
<br>
This is extracting List<TestConfig> configs =prepareRunProgram(classes, tests);<br>
with all he HW/switches setup to separated method and reusing it in `-l` mode<br>
<br>
I'm aware of triplicated removal of -agentlib, and will clean it up as<br>
CODETOOLS-7903756 will progress.<br>
<br>
-l now honours also verbose mode, in which it prints not just matching<br>
tests but all really run tests, and thus enabling much more easy<br>
determining of all tests<br>
<br>
help adjusted.<br>
<br>
Maybe I'm missing plain quick initial all tests metod now, but with <br>
artificial -c MAX it seems doing exactly that<br>
<br>
-------------<br>
<br>
Commit messages:<br>
- CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings<br>
- CODETOOLS-7903756 - jcstress shuld not pass debugging parameters to subproceses<br>
<br>
Changes: <a href="https://git.openjdk.org/jcstress/pull/149/files" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149/files</a><br>
Webrev: <a href="https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=00" rel="noreferrer" target="_blank">https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=00</a><br>
Issue: <a href="https://bugs.openjdk.org/browse/CODETOOLS-7903748" rel="noreferrer" target="_blank">https://bugs.openjdk.org/browse/CODETOOLS-7903748</a><br>
Stats: 103 lines in 6 files changed: 76 ins; 18 del; 9 mod<br>
Patch: <a href="https://git.openjdk.org/jcstress/pull/149.diff" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149.diff</a><br>
Fetch: git fetch <a href="https://git.openjdk.org/jcstress.git" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress.git</a> pull/149/head:pull/149<br>
<br>
PR: <a href="https://git.openjdk.org/jcstress/pull/149" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149</a><br>
<br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Tue, 2 Jul 2024 07:38:57 GMT<br>
From: Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>><br>
To: <<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a>><br>
Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings [v2]<br>
Message-ID:<br>
<yf-RhtSU9E7vVUj6I3ixiFQUdUNQA7IihlhIv11swcU=.<a href="mailto:67df85e6-a732-4ffb-942e-ef3fc41878a1@github.com" target="_blank">67df85e6-a732-4ffb-942e-ef3fc41878a1@github.com</a>><br>
<br>
Content-Type: text/plain; charset=utf-8<br>
<br>
> This is extracting List<TestConfig> configs =prepareRunProgram(classes, tests);<br>
> with all he HW/switches setup to separated method and reusing it in `-l` mode<br>
> <br>
> I'm aware of triplicated removal of -agentlib, and will clean it up as<br>
> CODETOOLS-7903756 will progress.<br>
> <br>
> -l now honours also verbose mode, in which it prints not just matching<br>
> tests but all really run tests, and thus enabling much more easy<br>
> determining of all tests<br>
> <br>
> help adjusted.<br>
> <br>
> Maybe I'm missing plain quick initial all tests metod now, but with <br>
> artificial -c MAX it seems doing exactly that<br>
<br>
Ji?? Van?k has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:<br>
<br>
CODETOOLS-7903748 - jcstress: Test list should honor concurrency settings<br>
<br>
This is extracting List<TestConfig> configs =prepareRunProgram(classes, tests);<br>
with all he HW/switches setup to separated method and reusing it in `-l` mode<br>
<br>
-l now honours also verbose mode, in which it prints not just matching<br>
tests but all really run tests, and thus enabling much more easy<br>
determining of all tests<br>
<br>
help adjusted.<br>
<br>
Maybe I'm missing plain quick initial all tests metod now, but with<br>
artificial -c MAX it seems doing exactly that<br>
<br>
-------------<br>
<br>
Changes:<br>
- all: <a href="https://git.openjdk.org/jcstress/pull/149/files" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149/files</a><br>
- new: <a href="https://git.openjdk.org/jcstress/pull/149/files/a52df414..58455e2d" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149/files/a52df414..58455e2d</a><br>
<br>
Webrevs:<br>
- full: <a href="https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=01" rel="noreferrer" target="_blank">https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=01</a><br>
- incr: <a href="https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=00-01" rel="noreferrer" target="_blank">https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=00-01</a><br>
<br>
Stats: 4 lines in 3 files changed: 0 ins; 2 del; 2 mod<br>
Patch: <a href="https://git.openjdk.org/jcstress/pull/149.diff" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149.diff</a><br>
Fetch: git fetch <a href="https://git.openjdk.org/jcstress.git" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress.git</a> pull/149/head:pull/149<br>
<br>
PR: <a href="https://git.openjdk.org/jcstress/pull/149" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149</a><br>
<br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Tue, 2 Jul 2024 07:38:57 GMT<br>
From: Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>><br>
To: <<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a>><br>
Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings<br>
Message-ID:<br>
<EqHUX9rfzYzgrPi83cDp6rTC9cTzaDREaLICLk3mFgY=.<a href="mailto:87b05cfc-eeb5-4082-96f8-e4b73ccf1da3@github.com" target="_blank">87b05cfc-eeb5-4082-96f8-e4b73ccf1da3@github.com</a>><br>
<br>
Content-Type: text/plain; charset=utf-8<br>
<br>
On Wed, 19 Jun 2024 12:58:28 GMT, Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>> wrote:<br>
<br>
> This is extracting List<TestConfig> configs =prepareRunProgram(classes, tests);<br>
> with all he HW/switches setup to separated method and reusing it in `-l` mode<br>
> <br>
> I'm aware of triplicated removal of -agentlib, and will clean it up as<br>
> CODETOOLS-7903756 will progress.<br>
> <br>
> -l now honours also verbose mode, in which it prints not just matching<br>
> tests but all really run tests, and thus enabling much more easy<br>
> determining of all tests<br>
> <br>
> help adjusted.<br>
> <br>
> Maybe I'm missing plain quick initial all tests metod now, but with <br>
> artificial -c MAX it seems doing exactly that<br>
<br>
Removed the unrelated commit. Ping please?<br>
<br>
-------------<br>
<br>
PR Comment: <a href="https://git.openjdk.org/jcstress/pull/149#issuecomment-2202178960" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149#issuecomment-2202178960</a><br>
<br>
<br>
------------------------------<br>
<br>
Message: 4<br>
Date: Tue, 2 Jul 2024 10:42:54 GMT<br>
From: Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>><br>
To: <<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a>><br>
Subject: RFR: CODETOOLS-7903756 - jcstress shuld not pass debugging<br>
parameters to subproceses<br>
Message-ID:<br>
<Lpr8mKtEiSMrWRYbNuk5uyAcQJ4T9STFe1QLCisdKPo=.<a href="mailto:9b65936c-24ac-4cfc-a0d8-0c1ea55d999a@github.com" target="_blank">9b65936c-24ac-4cfc-a0d8-0c1ea55d999a@github.com</a>><br>
<br>
Content-Type: text/plain; charset=utf-8<br>
<br>
No longer passing any -agentlib to subprocesses, unless it is part of -jvmArgsPrepend, thus allowing to debug both jcstress itself or wrked vm as expected:<br>
<br>
java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5005 -jar tests-all/target/jcstress.jar -c 1 -jvmArgsPrepend "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5006"<br>
<br>
works.<br>
<br>
-------------<br>
<br>
Commit messages:<br>
- CODETOOLS-7903756 - jcstress shuld not pass debugging parameters to subproceses<br>
<br>
Changes: <a href="https://git.openjdk.org/jcstress/pull/150/files" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/150/files</a><br>
Webrev: <a href="https://webrevs.openjdk.org/?repo=jcstress&pr=150&range=00" rel="noreferrer" target="_blank">https://webrevs.openjdk.org/?repo=jcstress&pr=150&range=00</a><br>
Issue: <a href="https://bugs.openjdk.org/browse/CODETOOLS-7903756" rel="noreferrer" target="_blank">https://bugs.openjdk.org/browse/CODETOOLS-7903756</a><br>
Stats: 14 lines in 3 files changed: 13 ins; 0 del; 1 mod<br>
Patch: <a href="https://git.openjdk.org/jcstress/pull/150.diff" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/150.diff</a><br>
Fetch: git fetch <a href="https://git.openjdk.org/jcstress.git" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress.git</a> pull/150/head:pull/150<br>
<br>
PR: <a href="https://git.openjdk.org/jcstress/pull/150" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/150</a><br>
<br>
<br>
End of jcstress-dev Digest, Vol 71, Issue 1<br>
*******************************************<br>
</blockquote></div>