<div dir="ltr"><div><br></div>Hello Team,<div><br></div><div><br></div><div><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Approved <b><u>openjdk/jcstress</u> PR : #149</b><br></div><div><br></div><div><a href="https://github.com/openjdk/jcstress/pull/149">https://github.com/openjdk/jcstress/pull/149</a><br></div><div><br></div><div><br></div><div>Both <b><u>openjdk/jcstress</u> PR : </b><b>#149</b> and <b>#150</b> are <b>Ready for Integration</b></div><div><br></div><div><a href="https://github.com/openjdk/jcstress/pull/149">https://github.com/openjdk/jcstress/pull/149</a><br></div><div><br></div><div><a href="https://github.com/openjdk/jcstress/pull/150">https://github.com/openjdk/jcstress/pull/150</a><br></div><div><br></div><div>Whoever has access kindly update the labels by removing `rfr` and adding `ready` ; and can proceed further for the process of merge</div><div><br></div></div></div></div><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><br></div>Regards,<div><b>Prakhar Makhija</b></div><div><br></div><div>+91 78294 00970<br></div><div><a href="mailto:matcdac@gmail.com" target="_blank">matcdac@gmail.com</a></div><div><a href="https://www.linkedin.com/in/prakhar-makhija-17794b107/" target="_blank">https://www.linkedin.com/in/prakhar-makhija-17794b107/</a><br></div><div><br></div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 4, 2024 at 1:42 PM <<a href="mailto:jcstress-dev-request@openjdk.org">jcstress-dev-request@openjdk.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Send jcstress-dev mailing list submissions to<br>
<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="https://mail.openjdk.org/mailman/listinfo/jcstress-dev" rel="noreferrer" target="_blank">https://mail.openjdk.org/mailman/listinfo/jcstress-dev</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:jcstress-dev-request@openjdk.org" target="_blank">jcstress-dev-request@openjdk.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:jcstress-dev-owner@openjdk.org" target="_blank">jcstress-dev-owner@openjdk.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of jcstress-dev digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Re: RFR: CODETOOLS-7903756 - jcstress shuld not pass<br>
debugging parameters to subproceses [v4] (PM)<br>
2. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings [v6] (Ji?? Van?k)<br>
3. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings [v5] (Ji?? Van?k)<br>
4. Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings [v4] (Ji?? Van?k)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Thu, 4 Jul 2024 08:04:38 GMT<br>
From: PM <<a href="mailto:duke@openjdk.org" target="_blank">duke@openjdk.org</a>><br>
To: <<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a>><br>
Subject: Re: RFR: CODETOOLS-7903756 - jcstress shuld not pass<br>
debugging parameters to subproceses [v4]<br>
Message-ID:<br>
<_7lwZ8HeK3Nzl8W8RzRWRB2hxib4tWP67nobrFmxKIw=.<a href="mailto:29566c3e-a475-465a-bd6c-3680ba8c0db0@github.com" target="_blank">29566c3e-a475-465a-bd6c-3680ba8c0db0@github.com</a>><br>
<br>
Content-Type: text/plain; charset=utf-8<br>
<br>
On Thu, 4 Jul 2024 06:25:05 GMT, Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>> wrote:<br>
<br>
>> No longer passing any -agentlib to subprocesses, unless it is part of -jvmArgsPrepend, thus allowing to debug both jcstress itself or wrked vm as expected:<br>
>> <br>
>> java -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5005 -jar tests-all/target/jcstress.jar -c 1 -jvmArgsPrepend "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=*:5006"<br>
>> <br>
>> works.<br>
><br>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:<br>
> <br>
> Removed unused imports<br>
<br>
looks good to me, ready to merge<br>
<br>
-------------<br>
<br>
Marked as reviewed by <a href="mailto:matcdac@github.com" target="_blank">matcdac@github.com</a> (no known OpenJDK username).<br>
<br>
PR Review: <a href="https://git.openjdk.org/jcstress/pull/150#pullrequestreview-2158252745" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/150#pullrequestreview-2158252745</a><br>
<br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Thu, 4 Jul 2024 08:11:44 GMT<br>
From: Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>><br>
To: <<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a>><br>
Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings [v6]<br>
Message-ID:<br>
<f0Df3-A9l-TXj1_XH8SXSZkDfSk6vmFMI7OdHUXfdiM=.<a href="mailto:e81a5b67-57f2-4127-8fc0-c61e1b664984@github.com" target="_blank">e81a5b67-57f2-4127-8fc0-c61e1b664984@github.com</a>><br>
<br>
Content-Type: text/plain; charset=utf-8<br>
<br>
> This is extracting List<TestConfig> configs =prepareRunProgram(classes, tests);<br>
> with all he HW/switches setup to separated method and reusing it in `-l` mode<br>
> <br>
> I'm aware of triplicated removal of -agentlib, and will clean it up as<br>
> CODETOOLS-7903756 will progress.<br>
> <br>
> -l now honours also verbose mode, in which it prints not just matching<br>
> tests but all really run tests, and thus enabling much more easy<br>
> determining of all tests<br>
> <br>
> help adjusted.<br>
> <br>
> Maybe I'm missing plain quick initial all tests metod now, but with <br>
> artificial -c MAX it seems doing exactly that<br>
<br>
Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:<br>
<br>
replaced long string concatenation with StringBuilder<br>
<br>
-------------<br>
<br>
Changes:<br>
- all: <a href="https://git.openjdk.org/jcstress/pull/149/files" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149/files</a><br>
- new: <a href="https://git.openjdk.org/jcstress/pull/149/files/713c5a2d..4ee850d8" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149/files/713c5a2d..4ee850d8</a><br>
<br>
Webrevs:<br>
- full: <a href="https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=05" rel="noreferrer" target="_blank">https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=05</a><br>
- incr: <a href="https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=04-05" rel="noreferrer" target="_blank">https://webrevs.openjdk.org/?repo=jcstress&pr=149&range=04-05</a><br>
<br>
Stats: 15 lines in 1 file changed: 3 ins; 0 del; 12 mod<br>
Patch: <a href="https://git.openjdk.org/jcstress/pull/149.diff" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149.diff</a><br>
Fetch: git fetch <a href="https://git.openjdk.org/jcstress.git" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress.git</a> pull/149/head:pull/149<br>
<br>
PR: <a href="https://git.openjdk.org/jcstress/pull/149" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149</a><br>
<br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Thu, 4 Jul 2024 08:11:44 GMT<br>
From: Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>><br>
To: <<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a>><br>
Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings [v5]<br>
Message-ID:<br>
<oF8OhnErRbWFpZKPrEQSH7ytHK3yJ0c_Hg1kxDytquQ=.<a href="mailto:057a5990-538c-4bab-9331-1680b65c283b@github.com" target="_blank">057a5990-538c-4bab-9331-1680b65c283b@github.com</a>><br>
<br>
Content-Type: text/plain; charset=utf-8<br>
<br>
On Thu, 4 Jul 2024 05:49:57 GMT, Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>> wrote:<br>
<br>
>> This is extracting List<TestConfig> configs =prepareRunProgram(classes, tests);<br>
>> with all he HW/switches setup to separated method and reusing it in `-l` mode<br>
>> <br>
>> I'm aware of triplicated removal of -agentlib, and will clean it up as<br>
>> CODETOOLS-7903756 will progress.<br>
>> <br>
>> -l now honours also verbose mode, in which it prints not just matching<br>
>> tests but all really run tests, and thus enabling much more easy<br>
>> determining of all tests<br>
>> <br>
>> help adjusted.<br>
>> <br>
>> Maybe I'm missing plain quick initial all tests metod now, but with <br>
>> artificial -c MAX it seems doing exactly that<br>
><br>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:<br>
> <br>
> LIST_OPTION_DESCRIPTION split to two lines<br>
<br>
Sorry for forced, push, that was typo in commit message<br>
<br>
-------------<br>
<br>
PR Comment: <a href="https://git.openjdk.org/jcstress/pull/149#issuecomment-2208365304" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149#issuecomment-2208365304</a><br>
<br>
<br>
------------------------------<br>
<br>
Message: 4<br>
Date: Thu, 4 Jul 2024 08:11:44 GMT<br>
From: Ji?? Van?k <<a href="mailto:jvanek@openjdk.org" target="_blank">jvanek@openjdk.org</a>><br>
To: <<a href="mailto:jcstress-dev@openjdk.org" target="_blank">jcstress-dev@openjdk.org</a>><br>
Subject: Re: RFR: CODETOOLS-7903748 - jcstress: Test list should honor<br>
concurrency settings [v4]<br>
Message-ID:<br>
<ettMqxF3_9U5MDHcAdwtuP0yh6K-22bx-toPJXGJfg0=.<a href="mailto:ebd770fa-da01-4e6c-90af-e81902be185f@github.com" target="_blank">ebd770fa-da01-4e6c-90af-e81902be185f@github.com</a>><br>
<br>
Content-Type: text/plain; charset=utf-8<br>
<br>
On Thu, 4 Jul 2024 07:55:45 GMT, PM <<a href="mailto:duke@openjdk.org" target="_blank">duke@openjdk.org</a>> wrote:<br>
<br>
>> I never had an intention to return valid json. It is used only in verbose output, to differentiate individual variants of tests. Wihtout the test id, it do no have sense, and the extended info in {} is... complicated. See eg:<br>
>> <br>
>> org.openjdk.jcstress.samples.api.API_01_Simple {[actor1, actor2], spinLoopStyle: Thread.onSpinWait(), threads: 2, forkId: 0, maxFootprintMB: 64, compileMode: 0, shClass: (PG 0, CG 0), (PG 0, CG 0), strideSize: 256, strideCount: 40, cpuMap: null, [-XX:+UseBiasedLocking]}<br>
>> org.openjdk.jcstress.samples.api.API_01_Simple {[actor1, actor2], spinLoopStyle: Thread.onSpinWait(), threads: 2, forkId: 0, maxFootprintMB: 64, compileMode: 0, shClass: (PG 0, CG 0), (PG 0, CG 0), strideSize: 256, strideCount: 40, cpuMap: null, [-XX:-UseBiasedLocking]}<br>
>> <br>
>> <br>
>> <br>
>> To highlight it is not json, was the original usage of `=`, but I did not had super strong opinion.<br>
>> As the output should remain mainly human readable, I'm quite against full json (thus bracket before name, and id before actorNames and jvmArgs). But on contrary, the list is indeed huge.<br>
>> <br>
>> All matching tests combinations - 3030696<br>
>> x<br>
>> All matching tests - 4483<br>
>> <br>
>> with most of the combinations.<br>
>> <br>
>> The main motivation is the line of ""All matching tests combinations - " + testsToPrint.size()" thus real number of run tests. The listing itself is (very) useful candy on top:<br>
>> <br>
>> java -jar tests-all/target/jcstress.jar -v -l -t org.openjdk.jcstress.samples.api.API_01_Simple <br>
>> ...<br>
>> All matching tests combinations - 96<br>
>> ...<br>
>> <br>
>> x<br>
>> <br>
>> java -jar tests-all/target/jcstress.jar -l -t org.openjdk.jcstress.samples.api.API_01_Simple <br>
>> ...<br>
>> All matching tests - 1<br>
>> ...<br>
>> <br>
>> <br>
>> <br>
>> So back to verbose listing output format - I intentionally kept it semi parse-able - grep/sed on output, and readable enough: name info in {} , all fields with key id, and obvious arrays in [] without key.<br>
>> **AFAICJ, the full json will lower the human readability.** <br>
>> <br>
>> What about this - with "-v" it would print it as it is - human readable, fully distinguishible. on "-vv or -vvv" it would print complete fully qulified json. WDYT?<br>
><br>
> ok sure, gotcha, the human readable output with `-v` option what you are printing right now should be fine, just one small change I would request, instead of doing string concatenation with the `+` operator, can we use append operation with String Builder or String Buffer whichever is more appropriate here<br>
<br>
Thanx, done!<br>
Maybe.. can I return back the "=" instead of ": " ?<br>
<br>
-------------<br>
<br>
PR Review Comment: <a href="https://git.openjdk.org/jcstress/pull/149#discussion_r1665308861" rel="noreferrer" target="_blank">https://git.openjdk.org/jcstress/pull/149#discussion_r1665308861</a><br>
<br>
<br>
End of jcstress-dev Digest, Vol 71, Issue 8<br>
*******************************************<br>
</blockquote></div>