minor feedback on OperationGroup.operation()

Alexander Kjäll alexander.kjall at gmail.com
Wed May 23 17:54:21 UTC 2018


Hi

The javadoc on this function states:

* Return a new {@link Operation} for a SQL that doesn't return any result,
* for example DDL. The result of this Operation is always null.

But the signature is

public Operation<S> operation(String sql);

Is there any reason that it's Operation<S> instead of Operation<Void>?

And another small thing, the javadoc bread text for connectOperation() says:

The lifecycle must be {@link Lifecycle#NEW} or
{@link Lifecycle#NEW_INACTIVE} when the {@link Operation} is executed.
Otherwise the {@link Operation} will complete exceptionally with
{@link SqlException}.

but the @throws clause says:

@throws IllegalStateException if this {@link Connection} is in a lifecycle
state other than {@link Lifecycle#NEW}.

Is it only NEW or both NEW and NEW_INACTIVE?

best regards
Alexander Kjäll


More information about the jdbc-spec-discuss mailing list