Latest push

[Mark Rotteveel]

On 27-10-2018 18:45, Mark Rotteveel wrote:
> On 22-10-2018 17:27, Douglas Surber wrote:
>> We just pushed updates to ADBA and AoJ.
>>
>> ADBA changes:
>>
>>     Removed Session.activate and Session.deactivate
>>     Revised Session.Lifecycle
>>     Revised Result.Column to be more consistent
>>
>> AoJ changes:
>>
>>     Updates to conform to ADBA changes
>>     Implemented all Operations
>>     Implemented real tests
>>
>> We have only run the tests with Oracle Database. If you can run on 
>> another database let us know what you find.
> 
> Some notes (they are bit random in order and importance, just putting 
> things when I find them):

Some more notes:

AoJ:

- MultiOperation.initFetchSize() and RowBaseOperation.initFetchSize() do 
not take into account that `java.sql.Statement.getFetchSize()` can 
return 0 in some drivers if it was not set (this is the same issue I 
reported in June). Replace `fetchSize = jdbcStatement.getFetchSize()` 
with `fetchSize = Math.max(jdbcStatement.getFetchSize(), 1)` (or maybe 
something higher than 1 for efficiency).
- This results in RowOperation.handleFetchRows() and 
RowPublisherOperation.handleFetchRows() to not fetch any rows (likely 
leading to infinite loops or simply no progress elsewhere)
- RowOperation.handleFetchRows() has apidoc saying "@return true if more 
rows remain", but the return type is Object and all it ever returns is 
`null`.


-- 
Mark Rotteveel