Feedback on JSR-221 maintenance release 4 (JDBC 4.4)

[Mark Rotteveel]

OK, so deprecation will follow later together with Permission, etc. I 
understand, that seems OK.

What about my other point? IMHO, the javadoc is now a bit confusing with 
the retention of the text:

"""
A SQLPermission object contains a name (also referred to as a "target 
name") but no actions list; there is either a named permission or there 
is not. The target name is the name of the permission (see below). The 
naming convention follows the hierarchical property naming convention. 
In addition, an asterisk may appear at the end of the name, following a 
".", or by itself, to signify a wildcard match. For example: 
loadLibrary.* and * signify a wildcard match, while *loadLibrary and a*b 
do not.
"""

Especially given the:

* "(see below)", referring to the now removed table
* The second part of the paragraph ("The naming convention ... a*b do 
not."), which I think never really applied for SQLPermission, but was 
copied (and modified?) from BasicPermission

The retained paragraph feels a bit as if you're falling into the middle 
of a conversation and have missed something ("OK, a SQLPermission has a 
name, but what is it?"), which is why I think it's probably better to 
retain the old text and together with the API note, it will be clear 
it's no longer used, and why.

And good to hear there are plans for a further maintenance release.

Mark

On 12/12/2024 16:54, Lance Andersen wrote:
> As indicated in JEP 486 <https://openjdk.org/jeps/486>:
> 
> ——————
> In a future release we will deprecate |Permission| and related classes 
> such as |BasicPermission|, |PermissionCollection|, and |Permissions|, 
> and also subclasses of |Permission| outside of the |java.security| 
>   package, such as |java.lang.RuntimePermission|, | 
> java.net.NetPermission|, and |java.lang.reflect.ReflectPermission|.
> 
> ------------------
> 
> Once the above occurs the same will be done for other classes such as 
> SQLPermission
> 
> 
> As a side note, I will be working on a small JDBC MR tentatively 
> targeted for JDK 26 at which point I hopefully will be in position to 
> deprecate this class and other Permission related classes within the JDK

-- 
Mark Rotteveel