hg: jdk/jdk: 8236859: WebSocket over authenticating proxy fails with NPE
daniel.fuchs at oracle.com
daniel.fuchs at oracle.com
Fri Jan 17 18:01:48 UTC 2020
Changeset: ed8e7bf32188
Author: dfuchs
Date: 2020-01-17 17:55 +0000
URL: https://hg.openjdk.java.net/jdk/jdk/rev/ed8e7bf32188
8236859: WebSocket over authenticating proxy fails with NPE
Summary: This change fixes several issues with WebSocket and proxy authentication. The AuthenticationFilter is changed to support an authenticating server accessed through an authenticating proxy. MultiExchange is fixed to close the previous connection if a new connection is necessary to establish the websocket (websocket connections are not cached and must be closed in that case). WebSocket OpeningHandshake is fixed to close the connection (without creating the RawChannel) if the opening handshake doesn't result in 101 upgrade protocol.
Reviewed-by: prappo, chegar
! src/java.net.http/share/classes/jdk/internal/net/http/AuthenticationFilter.java
! src/java.net.http/share/classes/jdk/internal/net/http/ConnectionPool.java
! src/java.net.http/share/classes/jdk/internal/net/http/Http1Response.java
! src/java.net.http/share/classes/jdk/internal/net/http/HttpResponseImpl.java
! src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java
! src/java.net.http/share/classes/jdk/internal/net/http/RawChannelTube.java
! src/java.net.http/share/classes/jdk/internal/net/http/common/Log.java
! src/java.net.http/share/classes/jdk/internal/net/http/websocket/OpeningHandshake.java
! src/java.net.http/share/classes/jdk/internal/net/http/websocket/RawChannel.java
+ test/jdk/java/net/httpclient/websocket/DummySecureWebSocketServer.java
+ test/jdk/java/net/httpclient/websocket/SecureSupport.java
! test/jdk/java/net/httpclient/websocket/WebSocketProxyTest.java
More information about the jdk-changes
mailing list