[PATCH] Mere code changes to silence some warnings

David CARLIER devnexen at gmail.com
Fri Dec 1 06:43:18 UTC 2017


Hi and thanks will do. Kind regards.

On 1 December 2017 at 00:57, David Holmes <david.holmes at oracle.com> wrote:

> Hi David,
>
> can you please split these and take them to the component mailing lists:
> hotspot changes to hotspot-dev, and the rest to core-libs-dev.
>
> BTW hotspot style nit - avoid implicit booleans: if (!p) -> if (p != NULL)
>
> Thanks,
> David H.
>
>
> On 1/12/2017 3:06 AM, David CARLIER wrote:
>
>> Hi dear list,
>>
>> Here a tiny patch to address few compilation warnings, two concerns UB
>> with
>> define e.g #define A <cond> it is usually better this form #if <cond>
>> #define A 1 ... Few types comparison miusmatches as well.
>>
>> Hope is all good ... tested full build.
>>
>>


More information about the jdk-dev mailing list