[10] RFR 8191510: Bump classfile version number to 54

[David Holmes]

On 5/12/2017 8:33 AM, Paul Sandoz wrote:
>> On 4 Dec 2017, at 13:53, David Holmes <david.holmes at oracle.com> wrote:
>>
>> On 5/12/2017 7:22 AM, Paul Sandoz wrote:
>>>> On 3 Dec 2017, at 13:13, David Holmes <david.holmes at oracle.com> wrote:
>>>>
>>>> Hi Paul,
>>>>
>>>> Don't you also need to update:
>>>>
>>>> jdk/src/java.base/share/native/include/classfile_constants.h
>>>>
>>>> #define JVM_CLASSFILE_MAJOR_VERSION 53
>>>>
>>> I cannot find any usages for this constant, nor JVM_CLASSFILE_MINOR_VERSION. I will remove them.
>>
>> Okay. I don't know the history or use of this file, other than it gets included into jvm.h to export the jvm interface to the jdk.
>>
> 
> And classfile_constants.h is also distributed with the image. I am unsure of the intent/history. To play it safe i will just bump the number.

Hmmm - that seems wrong. jvm.h is not an exported external interface 
AFAIK. And we just moved it so I don't think it will get distributed any 
more. Hmm that also suggests that classfile_constants.h may be in the 
wrong place ... I'll take this up elsewhere.

David

> Paul.
> 
>