review comments for JEP 12: Preview Language and VM Features JDK-8195734
Harold David Seigel
harold.seigel at oracle.com
Mon Dec 10 20:26:19 UTC 2018
Hi Alex,
On 12/10/2018 3:00 PM, Alex Buckley wrote:
> 3. The wording of the logging output is "Loading preview feature type
> $NAME". That sounds like the type is part of the preview feature,
> i.e., involved in supporting the preview feature, e.g., the
> java.lang.AutoCloseable type if the try-with-resources statement had
> been a preview feature. The word "type" also seems unusually abstract
> for logging output. Recommend "Loading class file that depends on
> preview features: $NAME", or, if it's redundant to say "Loading class
> file" in a log about class loading, then "$NAME depends on preview
> features of Java SE $RELEASE_THAT_CORRESPONDS_TO_MAJOR_VERSION"
We don't know if the class file actually depends on the preview
features, just that it was compiled with 65535. So, how about:
"Loading class file that is enabled for preview features: $NAME" ?
Thanks, Harold
More information about the jdk-dev
mailing list