RFR: JDK-8203927 - Update version string to identify which VM is being used

jesper.wilhelmsson at oracle.com jesper.wilhelmsson at oracle.com
Wed Jun 13 18:49:46 UTC 2018


Thank you Thomas!

Yes, the runtime dependent part is very useful when debugging installations where you have limited knowledge about the configuration.

Thanks,
/Jesper

> On 13 Jun 2018, at 20:44, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> 
> Looks fine to me too.
> 
> I was surprised to see though that the vm info string is actually
> dependent on runtime settings.
> 
> Thanks, Thomas
> 
> On Wed, Jun 13, 2018 at 8:33 PM,  <jesper.wilhelmsson at oracle.com> wrote:
>> Thank you for the review David!
>> /Jesper
>> 
>>> On 12 Jun 2018, at 11:24, David Holmes <david.holmes at oracle.com> wrote:
>>> 
>>> Hi Jesper,
>>> 
>>> Looks fine.
>>> 
>>> (I wish there was a better way to combine string literals to avoid the repetition - but I don't know of one.)
>>> 
>>> Thanks,
>>> David
>>> 
>>> On 12/06/2018 6:59 PM, jesper.wilhelmsson at oracle.com wrote:
>>>> Hi,
>>>> Please review this change to make the version string to identify which JVM is being used in the presence of a hardened JVM. This change relates to JDK-8202384 which is currently out for review as well.
>>>> Testing: Local verification and tier 1.
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8203927
>>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8203927/webrev.00/
>>>> Thanks,
>>>> /Jesper
>> 



More information about the jdk-dev mailing list