RFR: AArch64: JDK-8232046: AArch64 build failure after JDK-8225681
erik.osterlund at oracle.com
erik.osterlund at oracle.com
Fri Oct 11 12:04:17 UTC 2019
Hi Andrew,
Looks good to me. I feel like something is weird about the 0 is
logically -1 mapping (shouldn't it have populated the generic jump with
-1 in the first place instead?), but that weirdness should not hold back
this fix. Ship it.
Thanks,
/Erik
On 10/11/19 1:22 PM, Andrew Dinn wrote:
> ping!
>
> Is anyone willing to review this or do I have to wait for Andrew Haley
> to get back from his US trip?
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>
> On 10/10/2019 15:43, Andrew Dinn wrote:
>> Could I please have a review of the following patch AArch64-only which
>> fixes a build failure on AArch64 introduced by JDK-8225681:
>>
>> JIRA: https://bugs.openjdk.java.net/browse/JDK-8232046
>> webrev: http://cr.openjdk.java.net/~adinn/8232046/webrev.00/
>>
>> Testing:
>>
>> AArch64 build completes!
>>
>> tier1 tests pass
>> (modulo a few clearly unrelated errors)
>>
>>
>> vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine/TestDescription.java
>> passes
>> (that's the one JDK-8225681 was meant to fix)
More information about the jdk-dev
mailing list