[aarch64-port-dev ] RFR(XS): 8248219: aarch64: missing memory barrier in fast_storefield and fast_accessfield

[David Holmes]

Hi Felix,

On 7/07/2020 11:20 am, Yangfei (Felix) wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Andrew Haley [mailto:aph at redhat.com]
>> Sent: Monday, July 6, 2020 4:44 PM
>> To: Yangfei (Felix) <felix.yang at huawei.com>; hotspot-runtime-
>> dev at openjdk.java.net
>> Cc: aarch64-port-dev at openjdk.java.net
>> Subject: Re: [aarch64-port-dev ] RFR(XS): 8248219: aarch64: missing memory
>> barrier in fast_storefield and fast_accessfield
>>
>> On 06/07/2020 03:09, Yangfei (Felix) wrote:
>>> 1. For 8, I have prepared a backport webrev:
>> http://cr.openjdk.java.net/~fyang/8248219-8u-backport/webrev.00/
>>>       Jtreg tested with an 8u aarch64 release build.  OK for aarch64-
>> port/jdk8u-shenandoah?
>>
>> We need another approver. When we have one, please push to jdk8u-dev,
>> not jdk8u-shenandoah.
> 
> Hmm... I haven't seen an aarch64 port in jdk8u-dev yet.
> 
>>> 2. For 11, patch applies cleanly to jdk11u-dev and I have added a jdk11u-fix-
>> request label and corresponding comment on the issue.
>>
>> Please also add a jdk8u-fix-request.
> 
> I saw the jdk11u-fix-yes label was added and I have pushed to jdk11u-dev.
> As I remembered, jdk8u-fix-request label could be added when the aarch64 port is merged to jdk8u master.
> 
>>> 3. For 15, should I simply add 15 to " Affects Version/s" of the issue and
>> push to jdk/jdk15 after necessary test?
>>>       Please confirm if this is correct in procedure.
>>
>> I'm not sure.
> 
> CCing to jdk-dev.
> So the question is: Is it OK to push this fix to jdk/jdk15 for now given that JDK15 is currently in Rampdown Phase One?
> Could someone help elaborate on the correct procedure please?

This is a P3 bug and so can be fixed in RDP1 [1]. It could have been 
pushed directly to the jdk15 repo and would then have been automatically 
forward ported to the jdk repo for JDK 16. But it is fine to hg export 
from the main jdk repo and hg import into jdk15.

[1] http://openjdk.java.net/jeps/3#rdp-1

Thanks,
David
-----