closed bug in jdk: 8272867: JFR: ManagementSupport.removeBefore() lost coverage

[Langer, Christoph]

Hi,

Thanks, Kevin for filing this issue. I also hope this could be realized. Woud definitely be awesome!

Cheers
Christoph

> -----Original Message-----
> From: jdk-dev <jdk-dev-retn at openjdk.java.net> On Behalf Of Kevin
> Rushforth
> Sent: Dienstag, 21. September 2021 20:35
> To: jdk-dev at openjdk.java.net
> Subject: Re: closed bug in jdk: 8272867: JFR:
> ManagementSupport.removeBefore() lost coverage
> 
> I filed https://bugs.openjdk.java.net/browse/SKARA-1184 to track this.
> 
> Also, I opened up the bug in question.
> 
> https://bugs.openjdk.java.net/browse/JDK-8272867
> 
> -- Kevin
> 
> 
> On 9/21/2021 11:20 AM, Kevin Rushforth wrote:
> >
> > On 9/21/2021 11:12 AM, Kevin Rushforth wrote:
> >>
> >>
> >> On 9/21/2021 11:02 AM, Severin Gehwolf wrote:
> >>> On Tue, 2021-09-21 at 10:15 -0700, Joseph D. Darcy wrote:
> >>>> On 9/21/2021 10:06 AM, Severin Gehwolf wrote:
> >>>>> On Tue, 2021-09-21 at 16:33 +0000, Lindenmaier, Goetz wrote:
> >>>>>> Hi
> >>>>>>
> >>>>>> A change with a closed bug was pushed to jdk.
> >>>>>> Could this please be opened up?
> >>>>>>
> >>>>> I thought the point of skara was to fix issues like this? I see this
> >>>>> was the PR:
> >>>>> https://github.com/openjdk/jdk/pull/5453
> >>>>>
> >>>>> Would it be possible to make "Failed to retrieve information on issue
> >>>>> 8272867" an actual integration blocker by the bots? Or would that not
> >>>>> work for some corner-case I'm missing.
> >>>> That would not work for any of the fixes to security issues.
> >>> Aren't they pushed directly? Would these go through the PR workflow?
> >>
> >> Yes, they are typically pushed directly, and don't go through a
> >> GitHub workflow, so it might still be a feasible suggestion to make
> >> what is currently a warning, and integration blocker.
> >
> > There are two more good reasons to make this an integration blocker:
> >
> > 1. The Skara bot is unable to check the issue type of the JBS bug, or
> > verify that the PR title matches the bug summary.
> > 2. The Skara bot is unable to resolve the bug as fixed. This problem
> > is then amplified for backports.
> >
> > I'll file a JBS issue against Skara to track this. We will need to
> > double-check that there are no corner cases, but it seems promising to
> > me.
> >
> > -- Kevin
> >
> >
> >>
> >> -- Kevin
> >>
> >>
> >>>
> >>> Thanks,
> >>> Severin
> >>>
> >>
> >