Windows-x86 (32-bit) build is broken. Time to retire it?

[Stewart Addison]

Hi Magnus,

I put in a fix for another Win32 build break recently but hadn't realised
it was broken again - ref https://bugs.openjdk.org/browse/JDK-8319958.
Since the Win32 port is currently only deprecated I was already wondering
if we should go for the simple solution of having some github PR checks
added for Win32 along with the other platforms (Obviously it would need the
parameter to enable deprecated ports) as I feel this would help prevent
things being merged and subsequently backported that break things. In the
case of the one I fixed the PR that caused the build failure also got
backported to the JDK17 codebase - for which there are no plans to
deprecate - so potentially trapping things earlier would prevent such
problems seeping through to earlier versions requiring subsequent remedial
patches.

I think there's a discussion to be had here regarding 32-bit support in
general going forward - I have a specific question about arm32 and whether
anyone is actively maintaining that one but perhaps that's a matter for
another thread unless anyone wants to jump in and say they'll be keeping
arm32 alive in the codebase.

Regards,

Stewart...


On Tue, 5 Dec 2023 at 10:56, Magnus Ihse Bursie <
magnus.ihse.bursie at oracle.com> wrote:

> I just built windows-x86, and noticed that the build is broken:
>
> src\hotspot\share\prims\downcallLinker.cpp(36): error C2373:
> 'DowncallLinker::capture_state': redefinition; different type modifiers
>
> I think this is most likely caused by JDK-8254693, which was integrated
> three weeks ago. If no-one has discovered this, or bothered to fix it,
> maybe that is the signal we need to decide to actually stop pretending
> that windows-x86 is something we can build for, and just remove any
> remaining windows-x86 code?
>
> /Magnus
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk-dev/attachments/20231206/00efdee4/attachment-0001.htm>