Windows-x86 (32-bit) build is broken. Time to retire it?

[Lindenmaier, Goetz]

Hi,

Fixing issues on a non-standard platform is the task of the maintainers of
that platform. Others cannot be expected to have a build environment
around to assure correctness.  If an issue pops up in the GHA tests, it needs
to be fixed adhoc, else all other work is hindered. If the maintainers of a
platform are not able to assure that that happens, the platform should not be
tested in GHA.
And there are obviously very few people looking at the 32-bit windows
platform, else it would not break in head all the time.

Best regards,
  Goetz.



From: jdk-dev <jdk-dev-retn at openjdk.org> On Behalf Of Stewart Addison
Sent: Wednesday, December 6, 2023 2:23 PM
To: Alan Bateman <Alan.Bateman at oracle.com>
Cc: Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com>; jdk-dev at openjdk.org
Subject: Re: Windows-x86 (32-bit) build is broken. Time to retire it?

Some people who received this message don't often get email from sxa at redhat.com<mailto:sxa at redhat.com>. Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
> I assume this would put a tax on everyone, the testing in GHA is already
> a bit noisy. Seems like it would be better to remove the port

I can understand that, however we should bear in mind that with JDK<=17 being supported regardless, if it gets removed in a later version there is almost certainly a much higher risk of backports "breaking" the LTS streams (as it did recently) compared to other platforms without it being caught prior to integration, so it might be good to catch it earlier in the backport cycle (or maybe as a middle ground just add such checks to JDK<=17) regardless of whether it gets removed in >=21.

Regards,

Stewart...
--



On Wed, 6 Dec 2023 at 11:54, Alan Bateman <Alan.Bateman at oracle.com<mailto:Alan.Bateman at oracle.com>> wrote:
On 06/12/2023 10:22, Stewart Addison wrote:
> Hi Magnus,
>
> I put in a fix for another Win32 build break recently but hadn't
> realised it was broken again - ref
> https://bugs.openjdk.org/browse/JDK-8319958. Since the Win32 port is
> currently only deprecated I was already wondering if we should go for
> the simple solution of having some github PR checks added for Win32
> along with the other platforms (Obviously it would need the parameter
> to enable deprecated ports) as I feel this would help prevent things
> being merged and subsequently backported that break things.

I assume this would put a tax on everyone, the testing in GHA is already
a bit noisy. Seems like it would be better to remove the port, I think
it would be useful to hear from George Adams and Bruno Borges to know if
they plan to follow-up JEP 449 and do the next step.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk-dev/attachments/20231206/b10becfb/attachment-0001.htm>