[External] : Re: JEP proposed to target JDK 22: 461: Stream Gatherers (Preview)

[Viktor Klang]

Both concerns have now been addressed in the PR and CSR.

https://github.com/openjdk/jdk/pull/16420/commits/ec841740eb4cb6304243dd1b29a59acf9526bb79
[https://avatars.githubusercontent.com/u/114235711?s=400&v=4]<https://github.com/openjdk/jdk/pull/16420/commits/ec841740eb4cb6304243dd1b29a59acf9526bb79>
8319123: Implement JEP 461: Stream Gatherers (Preview) by viktorklang-ora · Pull Request #16420 · openjdk/jdk<https://github.com/openjdk/jdk/pull/16420/commits/ec841740eb4cb6304243dd1b29a59acf9526bb79>
This Pull-Request implements JEP-461 Progress Change must be properly reviewed (1 review required, with at least 1 Reviewer) Change must not contain extraneous whitespace Commit message must ...
github.com


Cheers,
√


Viktor Klang
Software Architect, Java Platform Group
Oracle
________________________________
From: jdk-dev <jdk-dev-retn at openjdk.org> on behalf of Viktor Klang <viktor.klang at oracle.com>
Sent: Tuesday, 21 November 2023 10:59
To: Daniel Schmid <daniel at wwwmaster.at>; jdk-dev at openjdk.org <jdk-dev at openjdk.org>; Mark Reinhold <mark.reinhold at oracle.com>
Subject: Re: [External] : Re: JEP proposed to target JDK 22: 461: Stream Gatherers (Preview)

No worries -- I agree that using initializer there seems more consistent, and it's already clear that it is a Supplier so repeating that seems unnecessary.

Cheers,
√


Viktor Klang
Software Architect, Java Platform Group
Oracle


________________________________
From: Daniel Schmid
Sent: Tuesday, November 21, 2023 10:41
To: Viktor Klang; jdk-dev at openjdk.org; Mark Reinhold
Subject: [External] : Re: JEP proposed to target JDK 22: 461: Stream Gatherers (Preview)


And another thing I realized after writing that E-Mail, the "initializer" parameter is called

> the supplier function for the new gatherer

I am unsure about the name "supplier function". After all, it is already named initializer so why not use the name initializer (function) instead of supplier function?


Am 21.11.2023 um 10:35 schrieb Viktor Klang:
Thanks for the feedback -- I agree that could be improved.
I'll address this in the PR/CSR shortly.

Cheers,
√


Viktor Klang
Software Architect, Java Platform Group
Oracle


________________________________
From: jdk-dev on behalf of Daniel Schmid
Sent: Tuesday, November 21, 2023 10:31
To: jdk-dev at openjdk.org<mailto:jdk-dev at openjdk.org>; Mark Reinhold
Subject: Re: JEP proposed to target JDK 22: 461: Stream Gatherers (Preview)

When reading the type parameters of the
"Gatherer.of"/"Gatherer.ofSequential" methods, I realized that the type
parameter for the intermediate state is documted as

 > the type of initializer for the new gatherer

While not being wrong, it looks a bit confusing to me as it refers to
the intermediate state which is also used by the integrator, that type
parameter is not exclusive to the initializer.

Is there a reason it is not called

 > the type of intermediate state for the new gatherer

or something similar?

Am 20.11.2023 um 17:17 schrieb Mark Reinhold:
> The following JEP is proposed to target JDK 22:
>
>    461: Stream Gatherers (Preview)
>         https://openjdk.org/jeps/461
>
>    Summary: Enhance the Stream API to support custom intermediate
>    operations.  This will allow stream pipelines to transform data in ways
>    that are not easily achievable with the existing built-in intermediate
>    operations.  This is a preview API.
>
> Feedback on this proposal from JDK Project Committers and Reviewers [1]
> is more than welcome, as are reasoned objections.  If no such objections
> are raised by 20:00 UTC on Wednesday, 29 November, or if they’re raised
> and then satisfactorily answered, then per the JEP 2.0 process proposal
> [2] I’ll target this JEP to JDK 22.
>
> - Mark
>
>
> [1] https://openjdk.org/census#jdk
> [2] https://cr.openjdk.java.net/~mr/jep/jep-2.0-02.html
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk-dev/attachments/20231121/5b97e7e3/attachment.htm>