Is webrev generation still relevant?

[Jaikiran Pai]

Hello Magnus,

On 18/01/24 2:34 pm, Magnus Ihse Bursie wrote:
> At the onset of Project Skara, one goal was to keep backwards 
> compatibility with developers' workflows. For this, a Skara bot was 
> created which generates webrevs, as closely aligned to the original 
> ksh webrev script as possible.
>
> Now I believe all developers are well into the Skara/GitHub way of 
> doing things, and I have not heard someone refer to webrevs in a long 
> time. So my first question is:
>
> * Is it still relevant to continue let the Skara bots generate webrevs?
>
> I personally have only used webrevs on a few occasions the last years, 
> and those have all been when the GitHub diff viewer was inadequate. 
> For instance, the webrev bot uses a more aggressive method of letting 
> git match files that have been simultaneously moved and edited, and 
> the Frames view align code side-by-side which is sometimes much more 
> helpful than the line-by-line view in GitHub. 

I don't know about the webrev generation implementation detail, but I 
always use webrev for reviewing changes. My workflow usually involves 
going to the github PR queue and for each PR, first finding the webrev 
comment and then using the "Full" webrev (and in a few cases 
"incremental") to do the reviews. The only reviews that I have done in 
the GitHub are for typos, copyright changes and such.

I find webrev interface to be much less "busy" and much more navigable 
compared to GitHub UI. That allows me to focus on the right set of 
changed files (sometimes one each in a separate tab).

-Jaikiran