CFV: New JDK Reviewer: Chen Liang. A comment, not a vote.

Claes Redestad claes.redestad at oracle.com
Mon Jun 10 07:42:42 UTC 2024



> 10 juni 2024 kl. 09:17 skrev David Holmes <david.holmes at oracle.com>:
> 
> On 8/06/2024 8:52 pm, Pavel Rappo wrote:
>> Alright, it's indeed an unusual situation. Let me explain.
>> Chen was nominated to JDK Committer on the 15th of May: https://mail.openjdk.org/pipermail/jdk-dev/2024-May/008964.html. Votes were due by the 29th of May. On the 30th of May, the nominator announced the result: https://mail.openjdk.org/pipermail/jdk-dev/2024-May/009039.html. From what I see, the third step will be eventually completed by updating the census: https://openjdk.org/projects/#project-reviewer.
> 
> It does rather beg the question as to why someone who is now considered experienced enough to be a Reviewer was never proposed as a Committer?

The error here I think is not calling the Reviewer vote early, but forgetting to call a Committer vote for so long. Chen has been a voracious reviewer who has eagerly reviewed, commented on and suggesting improvements to changes in several areas. Since his contributions come more from being an active reviewer than from churning out patches of his own I think many of us simply forgot that he has been stuck as Author for the longest time.

/Claes


More information about the jdk-dev mailing list