Improving OpenJDK for FreeBSD

[Magnus Ihse Bursie]

On 2025-02-21 04:03, David Holmes wrote:

> On 21/02/2025 2:17 am, Magnus Ihse Bursie wrote:
>> Hi Harald (and others),
>>
>> Great to see that you've made it this far! Sorry for the delayed 
>> responses, I've been ill for a while and are starting to work through 
>> my backlog now.
>>
>> On 2025-02-13 12:48, Harald Eilertsen wrote:
>>
>>> On Wed, Feb 05, 2025 at 11:25:51AM +1000, David Holmes wrote:
>>>> Hi Harald,
>>>>
>>>> Can you create a PR against mainline so that we can see the scope 
>>>> of the
>>>> changes and how they have been implemented?
>>> Here you go:
>>> https://github.com/openjdk/jdk/pull/23611
>>>
>>> As mentioned in the notes for the PR, this is mainly ment to get your
>>> feedback and as a draft to assess the scope, and to be a base for
>>> discussing how (and if) to proceed with the port.
>>
>> This was a good move. When actually integrating any code, a different 
>> approach will be needed (for instance, the original writer/copyright 
>> holder must be clear for every line of code that should be integrated 
>> so we can check OCA acceptance). I do believe that a piecewise 
>> integration is much preferable to trying to add everything once.
>>
>> That will however require us to accept that we for a while are going 
>> to have a port in the mainline that might not even successfully 
>> build, even less work. But I think that is preferable to a big 
>> massive integration.
>
> I would not like to see it happen that way. If it is to happen then I 
> would prefer to see a project established and a project repo. This 
> phased approach can be applied to the project repo and supporting 
> changes upstreamed to mainline, then eventually the port itself will 
> be integrated to mainline.

So are your suggested course of action to create a new bsd port repo, 
that starts out identical with mainline, and then integrate PRs into 
that, with usual review and JBS bug numbers, and when all PRs are in 
place, we can make a wholesale integration of that repo into mainline?

I think that could work as well, but I guess the difficult part will be 
to get reviewers from the relevant areas. Making PRs to mainline will 
ensure they get on the potential reviewers radar. I'm afraid that 
posting PRs on a separate port will just have them end up with a bunch 
of "Anyone?" posted every week, and if someone do show up to review 
them, it might not be the right person for the job.

But if you think we can solve that, I agree that it is probably a better 
solution.

Also, I don't know if this has been said before, but this work requires 
a JEP.

/Magnus


>
> Cheers,
> David
>
>> That reasoning also indicates that maybe the first parts that should 
>> go in is the build system changes that are needed to even try to 
>> build the BSD port...
>>
>> /Magnus
>>
>