<div dir="ltr">Hi,<div>I wanted to know what I can do to move <a href="https://github.com/openjdk/jdk/pull/13276">https://github.com/openjdk/jdk/pull/13276</a> along.</div><div>There was advice to create a CSR request, in order to do that there needs to be a jira </div><div>but I don't think I have permissions to create one.</div><div><br></div><div>Thanks for all the reviews, let me know what I can do, happy to follow your advice!</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 25, 2023 at 11:39 PM Kevin Walls <<a href="mailto:kevin.walls@oracle.com">kevin.walls@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="msg5702708828286768205">
<div lang="EN-GB">
<div class="m_5702708828286768205WordSection1">
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Hi,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">(I put this in the PR, but maybe drafts don’t get updates put on the mailing list?)<u></u><u></u></span></p>
<p style="margin-bottom:12pt;background:white"><span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:rgb(31,35,40)">HeapDumpOverwrite sounds quite general, there are different ways of heap dumping and this doesn't affect all of them. This could
be HeapDumpOnOutOfMemoryErrorOverwrite, which is a long option even for us 8-) so could be abbreviated perhaps, BUT that option might not be the way to do it…<u></u><u></u></span></p>
<p style="margin-bottom:12pt;background:white;box-sizing:border-box;font-variant-ligatures:normal;font-variant-caps:normal;text-align:start;text-decoration-style:initial;text-decoration-color:initial;word-spacing:0px">
<span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:rgb(31,35,40)">Is it really that all heap dumps should be permitted to an existing file, IF that file is a FIFO? From the email I think that's the problem? ..and if so, we have:<u></u><u></u></span></p>
<p style="margin-right:0cm;margin-bottom:12pt;margin-left:0cm;background:white;box-sizing:border-box;font-variant-ligatures:normal;font-variant-caps:normal;text-align:start;text-decoration-style:initial;text-decoration-color:initial;word-spacing:0px">
<span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:rgb(31,35,40)">8267666: Add option to jcmd GC.heap_dump to use existing file<br>
<a href="https://bugs.openjdk.org/browse/JDK-8267666" target="_blank"><span style="text-decoration:none">https://bugs.openjdk.org/browse/JDK-8267666</span></a><u></u><u></u></span></p>
<p style="margin-top:0cm;background:white;box-sizing:border-box;font-variant-ligatures:normal;font-variant-caps:normal;text-align:start;text-decoration-style:initial;text-decoration-color:initial;word-spacing:0px">
<span style="font-size:10.5pt;font-family:"Segoe UI",sans-serif;color:rgb(31,35,40)">So if jcmd to create a dump can use an existing file, -XX:OnError= can trigger such a jcmd?
<br>
<br>
i.e. Maybe there is a way of doing what you want. A code change could still be required to make this easier for heap dumps on out of memory. Writing a JBS bug first is useful to define the problem.<br>
<br>
Thanks<br>
Kevin<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11pt;font-family:Calibri,sans-serif">From:</span></b><span lang="EN-US" style="font-size:11pt;font-family:Calibri,sans-serif"> jdk-dev <<a href="mailto:jdk-dev-retn@openjdk.org" target="_blank">jdk-dev-retn@openjdk.org</a>>
<b>On Behalf Of </b>Elon Azoulay<br>
<b>Sent:</b> 25 May 2023 21:21<br>
<b>To:</b> Daniel Daugherty <<a href="mailto:daniel.daugherty@oracle.com" target="_blank">daniel.daugherty@oracle.com</a>><br>
<b>Cc:</b> <a href="mailto:serviceability-dev@openjdk.org" target="_blank">serviceability-dev@openjdk.org</a>; <a href="mailto:jdk-dev@openjdk.org" target="_blank">jdk-dev@openjdk.org</a><br>
<b>Subject:</b> Re: [External] : Re: Proposal: Add overwrite heapdump flag to java<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Sounds good, thanks so much!<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, May 25, 2023 at 12:13 PM <<a href="mailto:daniel.daugherty@oracle.com" target="_blank">daniel.daugherty@oracle.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<div>
<p class="MsoNormal" style="margin-bottom:12pt"><span style="font-family:"Courier New"">Pointing the older thread to this newer incarnation would be a good idea.<br>
<br>
Dan<br>
<br>
</span><u></u><u></u></p>
<div>
<p class="MsoNormal">On 5/25/23 3:11 PM, Elon Azoulay wrote:<u></u><u></u></p>
</div>
<blockquote style="margin-top:5pt;margin-bottom:5pt">
<div>
<p class="MsoNormal">Hi Dan, <u></u><u></u></p>
<div>
<p class="MsoNormal">That's great! Should I follow up in that thread as well?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, May 25, 2023 at 12:04 PM <<a href="mailto:daniel.daugherty@oracle.com" target="_blank">daniel.daugherty@oracle.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border-top:none;border-right:none;border-bottom:none;border-left:1pt solid rgb(204,204,204);padding:0cm 0cm 0cm 6pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal" style="margin-bottom:12pt">Greetings,<br>
<br>
A similar request came up on the hotspot-dev alias back in 2022.11:<br>
<br>
<a href="https://mail.openjdk.org/pipermail/hotspot-dev/2022-November/066956.html" target="_blank">https://mail.openjdk.org/pipermail/hotspot-dev/2022-November/066956.html</a><br>
<br>
Dan<br>
<br>
<br>
On 5/25/23 1:48 AM, David Holmes wrote:<br>
> Hi Elon,<br>
><br>
> I would suggest taking this up on serviceability-dev - cc'd.<br>
><br>
> On 25/05/2023 3:46 am, Elon Azoulay wrote:<br>
>> Hi,<br>
>> I submitted a pull request <br>
>> <<a href="https://urldefense.com/v3/__https:/github.com/openjdk/jdk/pull/13276__;!!ACWV5N9M2RV99hQ!P4XNOUSVFXTWEIX8H89o1hhVY4MkuYC-SezupmhJPMkq4ytSpJqLz-jQjNkp906DjKBK_EuRIoL1MtBM2AGEbVqkI0M$" target="_blank">https://github.com/openjdk/jdk/pull/13276</a>>
to expose the overwrite <br>
>> flag to HeapDumpOnOutOfMemoryError.<br>
>> The flag is already exposed to jcmd as -overwrite.This is to <br>
>> facilitate creating a heapdump within a container native environment.<br>
>> We use this internally to dump the heap dump to a fifo so that we <br>
>> could read it in a separate container.Let me know what needs to be <br>
>> done in terms of creating an issue and getting my pr merged.<br>
><br>
> Have you gone through the guide:<br>
><br>
> <a href="https://openjdk.org/guide/" target="_blank">https://openjdk.org/guide/</a><br>
><br>
> ?<br>
><br>
> You will need a JBS issue and also a CSR request as this proposes to <br>
> add a new manageable product flag.<br>
><br>
> Cheers,<br>
> David<br>
><br>
>> I am a new contributor and would be happy to contribute more!<br>
>><br>
>> Cheers,<br>
>><br>
>> Elon<u></u><u></u></p>
</blockquote>
</div>
</blockquote>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</blockquote>
</div>
</div>
</div>
</div></blockquote></div>