<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
ta</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Tom</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Johan Sjolen <johan.sjolen@oracle.com><br>
<b>Sent:</b> 07 November 2024 08:51<br>
<b>To:</b> Tom Mooney <Tom.Mooney@bjss.com><br>
<b>Cc:</b> jdk-dev@openjdk.org <jdk-dev@openjdk.org><br>
<b>Subject:</b> Re: Enhancements</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">[You don't often get email from johan.sjolen@oracle.com. Learn why this is important at
<a href="https://aka.ms/LearnAboutSenderIdentification">https://aka.ms/LearnAboutSenderIdentification</a> ]<br>
<br>
Hi Tom,<br>
<br>
I'd like to suggest that you watch this video (starting at the provided time stamp):
<a href="https://youtu.be/W-l0Huhb40s?feature=shared&t=2269">https://youtu.be/W-l0Huhb40s?feature=shared&t=2269</a><br>
<br>
> Is it good to define a general Definition of Done for this project so we can just work through a set of tasks to complete a ticket to maximise the chances our contributions will be accepted?<br>
<br>
A contributor ought to know enough context of the problem described in a ticket and can therefore make a meaningful contribution to its solution. The same goes for the reviewers. A DoD is not necessary for those people.<br>
<br>
If you want to maximize your chances of getting your contributions accepted, then start by doing small and easy contributions and stick around for the long term. You'll gain more influence that way.<br>
<br>
Cheers,<br>
Johan<br>
<br>
________________________________________<br>
From: jdk-dev <jdk-dev-retn@openjdk.org> on behalf of Ron Pressler <ron.pressler@oracle.com><br>
Sent: Wednesday, November 6, 2024 20:12<br>
To: Tom Mooney<br>
Cc: jdk-dev@openjdk.org<br>
Subject: Re: Enhancements<br>
<br>
Hi.<br>
<br>
It is important to understand that the challenge (and cost) of an enhancement isn’t in its implementation, however clean and well-tested it is (which is a bar all contributions must *ultimately* cross, anyway). Rather, any code in the JDK requires a long-term
commitment to maintain it (usually undertaken by the regular maintainers), and that cost needs to be considered against its benefit for the entire ecosystem. That benefit is greater the more programs can take advantage of the feature and the fewer programs
may be negatively affected by it (even if only by requiring developers to learn about a new feature so that they understand it when they encounter it; this is particularly difficult with language features). This is because OpenJDK is a critical piece of software
infrastructure.<br>
<br>
Depending on the enhancement, this consideration of cost (integrated over years of maintenance) vs benefit (integrated over the entire ecosystem) may be more challenging than implementing, testing, and documenting the feature, and requires the attention of
a small number of platform “stewards”, who can assess interaction risks, costs, and benefit.<br>
<br>
This consideration is a prerequisite for all enhancements, and so the main thing that greatly increases the chance of an enhancement being accepted (and reduces wasted work and disappointment) is beginning that conversation *before* contributing any code. Once
that discussion is done properly, the initial quality of implementation by the external contributor becomes secondary as it is not a significant portion of the total cost of the feature.<br>
<br>
— Ron<br>
<br>
> On 1 Nov 2024, at 14:08, Tom Mooney <Tom.Mooney@bjss.com> wrote:<br>
><br>
> Hi<br>
><br>
> Does OpenJDK accept enhancements from contributors at all? It was suggested previously to prefer fixing bugs over enhancements but if the enhancements aren't too risky and on the smaller side of medium in size and not too risky are they likely to be accepted
if you provide excellent test coverage, clean implementation and clear complete documentation that you'd done everything you need too. Is it good to define a general Definition of Done for this project so we can just work through a set of tasks to complete
a ticket to maximise the chances our contributions will be accepted?<br>
><br>
> Ta<br>
> Tom<br>
><br>
> The information included in this email and any files transmitted with it may contain information that is confidential and it must not be used by, or its contents or attachments copied or disclosed to, persons other than the intended addressee. If you have
received this email in error, please notify BJSS. In the absence of written agreement to the contrary BJSS' relevant standard terms of contract for any work to be undertaken will apply. Please carry out virus or such other checks as you consider appropriate
in respect of this email. BJSS does not accept responsibility for any adverse effect upon your system or data in relation to this email or any files transmitted with it. BJSS Limited, a company registered in England and Wales (Company Number 2777575), VAT
Registration Number 613295452, Registered Office Address, 1 Whitehall Quay, Leeds, LS1 4HR<br>
<br>
<br>
</div>
</span></font></div>
<br>
<p class="MsoNormal"><span style="font-size:8.0pt;font-family:"Arial",sans-serif">The information included in this email and any files transmitted with it may contain information that is confidential and it must not be used by, or its contents or attachments
copied or disclosed to, persons other than the intended addressee. If you have received this email in error, please notify BJSS. In the absence of written agreement to the contrary BJSS' relevant standard terms of contract for any work to be undertaken will
apply. Please carry out virus or such other checks as you consider appropriate in respect of this email. BJSS does not accept responsibility for any adverse effect upon your system or data in relation to this email or any files transmitted with it. BJSS Limited,
a company registered in England and Wales (Company Number 2777575), VAT Registration Number 613295452, Registered Office Address, 1 Whitehall Quay, Leeds, LS1 4HR</span></p>
</body>
</html>