<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:12.0pt;
font-family:"Aptos",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1238630734;
mso-list-template-ids:1504624702;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style>
</head>
<body lang="DE" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">Hi Harald and Thomas,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">>
</span><span lang="EN-US">- PPC changes: we already deal with AIX and Linux, and adding BSD is getting a bit #ifdef heavy. I wonder whether we should factor certain things out into (aix|bsd|linux)_ppc.cpp. For example, all of these os/cpu combinations use the
same register set, but the ucontext is different for every one of them, so a utility function like `get_gpr_from_context(const ucontext_t* c, int num)` would help. Ultimately, that is up to Martin as ppc lead (I set him on cc).<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Right, we should think about some refactoring. In addition, I don’t like having to maintain exact copies of some files for AIX/BSD/Linux.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">I think such changes would be appreciated.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">One more thing about PPC64: We are planning to remove Power7 support (and older):
</span><span style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D"><a href="https://bugs.openjdk.org/browse/JDK-8331859"><span lang="EN-US" style="color:#0052CC">JDK-8331859</span></a></span><span lang="EN-US" style="font-size:10.5pt;font-family:"Arial",sans-serif;color:#172B4D"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">If anybody is willing to keep old processors supported and is also willing to keep testing them, we may discuss that.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Best regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Martin</span><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="color:black">Von:
</span></b><span style="color:black">Thomas Stüfe <thomas.stuefe@gmail.com><br>
<b>Datum: </b>Freitag, 14. Februar 2025 um 08:32<br>
<b>An: </b>Harald Eilertsen <harald+jdklists@volse.no><br>
<b>Cc: </b>JDK Dev list <jdk-dev@openjdk.org>, porters-dev <porters-dev@openjdk.org>, David Holmes <david.holmes@oracle.com>, Doerr, Martin <martin.doerr@sap.com><br>
<b>Betreff: </b>Re: Improving OpenJDK for FreeBSD<o:p></o:p></span></p>
</div>
<div>
<div>
<p class="MsoNormal">Hi Harald,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">In addition to what David wrote:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">- PPC changes: we already deal with AIX and Linux, and adding BSD is getting a bit #ifdef heavy. I wonder whether we should factor certain things out into (aix|bsd|linux)_ppc.cpp. For example, all of these os/cpu combinations use the same
register set, but the ucontext is different for every one of them, so a utility function like `get_gpr_from_context(const ucontext_t* c, int num)` would help. Ultimately, that is up to Martin as ppc lead (I set him on cc).<br>
<br>
- the bigger issue to me is the amount of large ifdef sections added to os/bsd and bsd/<arch> : I think its time to separate MacOS from BSD and make both first-class OSes. The amount of duplicate coding would be outweighed by clearer code. Up for discussion,
of course; that is just my gut feeling right now.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Cheers, Thomas<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><br>
<br>
<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Thu, Feb 13, 2025 at 12:49<span style="font-family:"Arial",sans-serif"> </span>PM Harald Eilertsen <<a href="mailto:harald%2Bjdklists@volse.no">harald+jdklists@volse.no</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">On Wed, Feb 05, 2025 at 11:25:51AM +1000, David Holmes wrote:<br>
> Hi Harald,<br>
><br>
> Can you create a PR against mainline so that we can see the scope of the<br>
> changes and how they have been implemented?<br>
<br>
Here you go:<br>
<a href="https://github.com/openjdk/jdk/pull/23611" target="_blank">https://github.com/openjdk/jdk/pull/23611</a><br>
<br>
As mentioned in the notes for the PR, this is mainly ment to get your<br>
feedback and as a draft to assess the scope, and to be a base for<br>
discussing how (and if) to proceed with the port.<br>
<br>
Looking forward to your thoughts and feedback!<br>
<br>
Harald Eilertsen<br>
--<br>
Eilertsens Kodeknekkeri<br>
<a href="https://kodeknekkeriet.net/" target="_blank">https://kodeknekkeriet.net</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</body>
</html>