<div dir="ltr"><div>Hi Harald,</div><div><br></div><div>In addition to what David wrote:</div><div><br></div><div>- PPC changes: we already deal with AIX and Linux, and adding BSD is getting a bit #ifdef heavy. I wonder whether we should factor certain things out into (aix|bsd|linux)_ppc.cpp. For example, all of these os/cpu combinations use the same register set, but the ucontext is different for every one of them, so a utility function like `get_gpr_from_context(const ucontext_t* c, int num)` would help. Ultimately, that is up to Martin as ppc lead (I set him on cc).<br><br>- the bigger issue to me is the amount of large ifdef sections added to os/bsd and bsd/<arch> : I think its time to separate MacOS from BSD and make both first-class OSes. The amount of duplicate coding would be outweighed by clearer code. Up for discussion, of course; that is just my gut feeling right now.</div><div><br></div><div>Cheers, Thomas</div><div><br><br><br></div></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Thu, Feb 13, 2025 at 12:49 PM Harald Eilertsen <<a href="mailto:harald%2Bjdklists@volse.no">harald+jdklists@volse.no</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Feb 05, 2025 at 11:25:51AM +1000, David Holmes wrote:<br>
> Hi Harald,<br>
><br>
> Can you create a PR against mainline so that we can see the scope of the<br>
> changes and how they have been implemented?<br>
<br>
Here you go:<br>
<a href="https://github.com/openjdk/jdk/pull/23611" rel="noreferrer" target="_blank">https://github.com/openjdk/jdk/pull/23611</a><br>
<br>
As mentioned in the notes for the PR, this is mainly ment to get your<br>
feedback and as a draft to assess the scope, and to be a base for<br>
discussing how (and if) to proceed with the port.<br>
<br>
Looking forward to your thoughts and feedback!<br>
<br>
Harald Eilertsen<br>
--<br>
Eilertsens Kodeknekkeri<br>
<a href="https://kodeknekkeriet.net" rel="noreferrer" target="_blank">https://kodeknekkeriet.net</a><br>
</blockquote></div>