hg: jdk/sandbox: 8221685: -XX:BytecodeVerificationRemote and -XX:BytecodeVerificationLocal should be diagnostic options

[chris.hegarty at oracle.com]

Changeset: b6db97903b69
Author:    hseigel
Date:      2019-04-24 08:27 -0400
URL:       http://hg.openjdk.java.net/jdk/sandbox/rev/b6db97903b69

8221685: -XX:BytecodeVerificationRemote and -XX:BytecodeVerificationLocal should be diagnostic options
Summary: Make the options diagnostic and add -XX:+UnlockDiagnosticVMOptions to tests where needed.
Reviewed-by: lfoltan, acorn, dholmes

! src/hotspot/share/runtime/globals.hpp
! test/hotspot/jtreg/compiler/linkage/TestLinkageErrorInGenerateOopMap.java
! test/hotspot/jtreg/runtime/Nestmates/privateMethods/TestInvokeErrors.java
! test/hotspot/jtreg/runtime/appcds/VerifierTest.java
! test/hotspot/jtreg/runtime/clone/invokevirtual/HasLocalClone.jasm
! test/hotspot/jtreg/runtime/clone/invokevirtual/NoLocalClone.jasm
! test/hotspot/jtreg/runtime/clone/invokevirtual/NoLocalCloneAbstr.jasm
! test/hotspot/jtreg/runtime/lambda-features/TestStaticandInstance.java
! test/hotspot/jtreg/runtime/verifier/TestSigParse.java
! test/hotspot/jtreg/vmTestbase/vm/mlvm/anonloader/stress/parallelLoad/Test.java