hg: jdk/sandbox: 8231606: _method_ordering is not set during CDS dynamic dump time

[chris.hegarty at oracle.com]

Changeset: 319173c62caa
Author:    ccheung
Date:      2019-10-02 16:55 -0700
URL:       https://hg.openjdk.java.net/jdk/sandbox/rev/319173c62caa

8231606: _method_ordering is not set during CDS dynamic dump time
Summary: Add the missing DynamicDumpSharedSpaces check in sort_methods(); replace the (DumpSharedSpaces || DynamicDumpSharedSpaces) with the Arguments::is_dumping_archive() function call.
Reviewed-by: iklam, coleenp, jiangli

! src/hotspot/share/classfile/classFileParser.cpp
! src/hotspot/share/classfile/classLoader.cpp
! src/hotspot/share/classfile/classLoader.hpp
! src/hotspot/share/classfile/classLoader.inline.hpp
! src/hotspot/share/classfile/classLoaderExt.cpp
! src/hotspot/share/classfile/compactHashtable.cpp
! src/hotspot/share/classfile/dictionary.cpp
! src/hotspot/share/classfile/klassFactory.cpp
! src/hotspot/share/classfile/symbolTable.cpp
! src/hotspot/share/classfile/systemDictionaryShared.cpp
! src/hotspot/share/classfile/verificationType.cpp
! src/hotspot/share/jfr/recorder/jfrRecorder.cpp
! src/hotspot/share/memory/filemap.cpp
! src/hotspot/share/memory/metaspaceShared.cpp
! src/hotspot/share/memory/universe.cpp
! src/hotspot/share/oops/constMethod.hpp
! src/hotspot/share/oops/cpCache.cpp
! src/hotspot/share/oops/instanceKlass.cpp
! src/hotspot/share/oops/klass.cpp
! src/hotspot/share/oops/method.cpp
! src/hotspot/share/runtime/arguments.cpp
! src/hotspot/share/runtime/arguments.hpp
! src/hotspot/share/runtime/thread.cpp
! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/HelloDynamic.java