[10u-communication] jdk10u forest & process changes

[Rob McKenna]

Hi Aleksey,

On 24/04/18 11:54, Aleksey Shipilev wrote:
> Hi again,
> 
> On 03/02/2018 07:57 PM, Rob McKenna wrote:
> > As we move into the second update release in the JDK Updates Project
> > we'd like to apply some of the lessons learned over the past couple of
> > months.
> > 
> > The first, of course, was the changes to the maintainership process [1].
> > 
> > Also, from now on fixes pushed to the jdk-updates repo will have a fix
> > version in the following format: <release>u-open. I.e. 10u-open in the
> > case of jdk10u. Once the fix has been approved for inclusion in an update
> > release, a corresponding bug record with the correct update release
> > version will be created. (e.g. 10.0.1)
> 
> I have a few 10u backports assigned to me, and now I have a few questions:
> 
>  a) Push approval [1] basically says that having jdk10u-fix-yes is the necessary condition for the
> push. Is it sufficient condition? In other words, if the bugfix has jdk10u-fix-yes label, can it be
> pushed? There are some interactions with CSR process, I think... In other words, does jdk10u-fix-yes
> label means maintainers have verified all the pieces are in order?

Great question. And one that should be documented on the project pages.
As with codereviews, the requester should ensure that the appropriate
approvals have been sought (and granted!). The maintainer should confirm
the status of the codereview and any necessary CSR approvals are in
place before adding the jdkXXu-fix-yes label. (as they seem to be in
this case?)

> 
>  b) The paragraph above seems to imply that "corresponding bug record" would be created on approval.
> I understand that backport JBS issues are created by hg updater after the push. But "on approval"? I
> see no JDK 10 backports for currently approved issues [2].
> 

Yes, thats poorly worded. It is referring to the records created as a
result of the push.

>  c) There are issues that already have backport JBS entries due to involvement with CSR process,
> e.g. [3][4]. Do we need to do anything special for them? Or the automatic update process would
> handle this gracefully? For example, do we still push the changes under "parent" bugid, or we under
> the manual backport bugid?

Always push under the parent bug id.

The 10 release has already GA'd so this fixVersion doesn't make sense.
It should be changed to 10u-open (10-pool should also work) so this issue
will get updated when the push occurs.

    -Rob

> 
> Thanks,
> -Aleksey
> 
> [1] http://openjdk.java.net/projects/jdk-updates/approval.html
> [2]
> https://bugs.openjdk.java.net/issues/?jql=labels%20%3D%20jdk10u-fix-yes%20ORDER%20BY%20updated%20DESC
> [3] https://bugs.openjdk.java.net/browse/JDK-8194554
> [4] https://bugs.openjdk.java.net/browse/JDK-8201502
>