[jdk-updates-communication] Push approval rule changes

Rob McKenna rob.mckenna at oracle.com
Thu Apr 26 15:23:40 UTC 2018


A number of push approval requests have been filed which do not obviously
meet the criteria laid out in the push approval project page. [1] I.e.
that they are:

- P1 bug, or
- A serious regression which needs fixing ASAP

In order to help the maintainers understand the context in which a request
is being made we are updating the rules for requesting push approval [1]
effective immediately. This consists of replacing rule 1 with the
following text:

When requesting push approval for a fix the requester must update the JBS
issue to add a comment whose first line is "Fix Request". In that comment
the requester must describe why it's important to fix this bug, explain
the nature of the fix, estimate its risk and describe its test coverage.
Additionally the comment should note whether the patch from the JDK
Project applies cleanly. If not, the fix MUST be codereviewed in public
and a public url to that review MUST be provided in the comment.

If a change requires CSR[2] approval, that approval must be obtained prior
to making the push approval request.

    -Rob

[1] http://openjdk.java.net/projects/jdk-updates/approval.html
[2] https://wiki.openjdk.java.net/display/csr/CSR+FAQs



More information about the jdk-updates-dev mailing list