[10u] RFR: 8202784: generated-configure.sh changes missing in 8201495
Tim Bell
tim.bell at oracle.com
Tue May 8 14:53:48 UTC 2018
See below-
On 05/08/18 07:39, Severin Gehwolf wrote:
> Hi,
>
> On Tue, 2018-05-08 at 15:20 +0100, Rob McKenna wrote:
>> No, you're correct. The closed changes do need to be handled by someone
>> in Oracle so it makes sense to get an Oracle committer to push.
>>
>> So:
>>
>> A. Yes.
>> B. You're absolutely right. I'll take care of the push once you've got
>> the change codereviewed / approved for push.
>
> Thank you, Rob!
>
> This seems a rather strange case as the actual change is already
> pushed[1]. What's missing are the generated-configure.sh changes after
> "bash make/autoconf/autogen.sh". Not sure what needs to get code-
> reviewed in this case.
>
> Getting the latest revision (ddb10178cbb2) from jdk-updates/jdk10u and
> then performing the autogen.sh step should give you the changes that
> need to get pushed. That's what the following webrev is:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8202784
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8202784/webrev.01/
>
> Anyway, can somebody on the build-team rubber-stamp this, please?
The make/autoconf/generated-configure.sh changes look good. Approved.
Over to Rob for the pushing, including the closed generated-configure.sh.
Tim
>
> Thanks,
> Severin
>
> [1] http://hg.openjdk.java.net/jdk-updates/jdk10u/rev/2f8a4aafe85f
More information about the jdk-updates-dev
mailing list