From goetz.lindenmaier at sap.com Tue Nov 6 12:21:25 2018 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Tue, 6 Nov 2018 12:21:25 +0000 Subject: RFR(S): 8210040: [TESTBUG] TestOptionsWithRanges is very slow Message-ID: <04f13204aabf4da99617927197fb1b6b@sap.com> Hi, I would like to downport this change as it improves the test runtimes nicely. Unfortunately the first chunk for TestOptionsWithRanges.java does not apply because "* @bug 8205633" was added in 12 which is in the unchanged context. That change has no effect on this test fix. Adapted webrev: http://cr.openjdk.java.net/~goetz/wr18/8210040-OptionWithRanges-jdk11/01/ https://bugs.openjdk.java.net/browse/JDK-8210040 8205633: http://hg.openjdk.java.net/jdk/jdk/rev/677e21d875ae https://bugs.openjdk.java.net/browse/JDK-8205633 Best regards, Goetz. From thomas.schatzl at oracle.com Wed Nov 7 23:31:16 2018 From: thomas.schatzl at oracle.com (Thomas Schatzl) Date: Thu, 08 Nov 2018 00:31:16 +0100 Subject: RFR(S): 8210040: [TESTBUG] TestOptionsWithRanges is very slow In-Reply-To: <04f13204aabf4da99617927197fb1b6b@sap.com> References: <04f13204aabf4da99617927197fb1b6b@sap.com> Message-ID: <45837e5153477cd4ab31eebb6d3e640e2053cdbb.camel@oracle.com> Hi, On Tue, 2018-11-06 at 12:21 +0000, Lindenmaier, Goetz wrote: > Hi, > > I would like to downport this change as it improves the test runtimes > nicely. > > Unfortunately the first chunk for TestOptionsWithRanges.java does > not apply because "* @bug 8205633" was added in 12 which is > in the unchanged context. > That change has no effect on this test fix. > > Adapted webrev: > http://cr.openjdk.java.net/~goetz/wr18/8210040-OptionWithRanges-jdk11/01/ > https://bugs.openjdk.java.net/browse/JDK-8210040 > > 8205633: > http://hg.openjdk.java.net/jdk/jdk/rev/677e21d875ae > https://bugs.openjdk.java.net/browse/JDK-8205633 backport looks good. Thomas From goetz.lindenmaier at sap.com Thu Nov 8 07:42:27 2018 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Thu, 8 Nov 2018 07:42:27 +0000 Subject: RFR(S): 8210040: [TESTBUG] TestOptionsWithRanges is very slow In-Reply-To: <45837e5153477cd4ab31eebb6d3e640e2053cdbb.camel@oracle.com> References: <04f13204aabf4da99617927197fb1b6b@sap.com> <45837e5153477cd4ab31eebb6d3e640e2053cdbb.camel@oracle.com> Message-ID: Hi Thomas, thanks for looking at this! Best regards, Goetz. > -----Original Message----- > From: Thomas Schatzl > Sent: Donnerstag, 8. November 2018 00:31 > To: Lindenmaier, Goetz ; jdk-updates- > dev at openjdk.java.net > Subject: Re: RFR(S): 8210040: [TESTBUG] TestOptionsWithRanges is very slow > > Hi, > > On Tue, 2018-11-06 at 12:21 +0000, Lindenmaier, Goetz wrote: > > Hi, > > > > I would like to downport this change as it improves the test runtimes > > nicely. > > > > Unfortunately the first chunk for TestOptionsWithRanges.java does > > not apply because "* @bug 8205633" was added in 12 which is > > in the unchanged context. > > That change has no effect on this test fix. > > > > Adapted webrev: > > > http://cr.openjdk.java.net/~goetz/wr18/8210040-OptionWithRanges-jdk11/01/ > > https://bugs.openjdk.java.net/browse/JDK-8210040 > > > > 8205633: > > http://hg.openjdk.java.net/jdk/jdk/rev/677e21d875ae > > https://bugs.openjdk.java.net/browse/JDK-8205633 > > backport looks good. > > Thomas > From martin.doerr at sap.com Thu Nov 8 09:18:23 2018 From: martin.doerr at sap.com (Doerr, Martin) Date: Thu, 8 Nov 2018 09:18:23 +0000 Subject: RFR(S): 8210040: [TESTBUG] TestOptionsWithRanges is very slow In-Reply-To: References: <04f13204aabf4da99617927197fb1b6b@sap.com> <45837e5153477cd4ab31eebb6d3e640e2053cdbb.camel@oracle.com> Message-ID: <74069f8790a64329adf882202e6f1677@sap.com> Hi G?tz, thanks for backporting. Ok, the only change was that you had to omit the @bug line to resolve it. This looks good. Best regards, Martin -----Original Message----- From: jdk-updates-dev On Behalf Of Lindenmaier, Goetz Sent: Donnerstag, 8. November 2018 08:42 To: Thomas Schatzl ; jdk-updates-dev at openjdk.java.net Subject: [CAUTION] RE: RFR(S): 8210040: [TESTBUG] TestOptionsWithRanges is very slow Hi Thomas, thanks for looking at this! Best regards, Goetz. > -----Original Message----- > From: Thomas Schatzl > Sent: Donnerstag, 8. November 2018 00:31 > To: Lindenmaier, Goetz ; jdk-updates- > dev at openjdk.java.net > Subject: Re: RFR(S): 8210040: [TESTBUG] TestOptionsWithRanges is very slow > > Hi, > > On Tue, 2018-11-06 at 12:21 +0000, Lindenmaier, Goetz wrote: > > Hi, > > > > I would like to downport this change as it improves the test runtimes > > nicely. > > > > Unfortunately the first chunk for TestOptionsWithRanges.java does > > not apply because "* @bug 8205633" was added in 12 which is > > in the unchanged context. > > That change has no effect on this test fix. > > > > Adapted webrev: > > > http://cr.openjdk.java.net/~goetz/wr18/8210040-OptionWithRanges-jdk11/01/ > > https://bugs.openjdk.java.net/browse/JDK-8210040 > > > > 8205633: > > http://hg.openjdk.java.net/jdk/jdk/rev/677e21d875ae > > https://bugs.openjdk.java.net/browse/JDK-8205633 > > backport looks good. > > Thomas > From goetz.lindenmaier at sap.com Wed Nov 28 09:00:22 2018 From: goetz.lindenmaier at sap.com (Lindenmaier, Goetz) Date: Wed, 28 Nov 2018 09:00:22 +0000 Subject: RFR(S) [downport 11]: 8213410: UseCompressedOops requirement check fails fails on 32-bit system Message-ID: <0a52708b571f4c729664900b4a7e5bd1@sap.com> Hi, I need a review to downport 8213410. 8213410 fixes disabling tests for UseCompressedOops on 32-bit platforms. In jdk12, "@requires vm.bits == 64" was introduced to CompressedClassPointers.java by "8208655: use JTreg skipped status in hotspot tests". Because of this change, 8213410 does not apply properly. To fix this, I introduce "@requires vm.bits == 64" to this test in jdk11, too. http://cr.openjdk.java.net/~goetz/wr18/8213410-32bit_cOops-jdk11/01/ Best regards, Goetz.