jdk11u: Windows 32 bit broken

[Severin Gehwolf]

Hi Martin,

On Fri, 2018-10-12 at 08:24 +0000, Doerr, Martin wrote:
> Hi Severin,
> 
> thanks for the quick reply and for opening the bug.
> If you have a patch, we can assist with testing.

See:
http://mail.openjdk.java.net/pipermail/build-dev/2018-October/023607.html

Please test!

Thanks,
Severin

> We only build 32 bit with jdk11u, no longer with jdk/jdk that's why
> we didn't notice it before today.
> 
> Best regards,
> Martin
> 
> 
> -----Original Message-----
> From: Severin Gehwolf <sgehwolf at redhat.com> 
> Sent: Freitag, 12. Oktober 2018 10:20
> To: Doerr, Martin <martin.doerr at sap.com>; 
> jdk-updates-dev at openjdk.java.net
> Cc: Baesken, Matthias <matthias.baesken at sap.com>
> Subject: Re: jdk11u: Windows 32 bit broken
> 
> Hi Martin,
> 
> On Fri, 2018-10-12 at 07:47 +0000, Doerr, Martin wrote:
> > Hi Severin,
> >  
> > we noticed that the Windows 32 bit build fails with the latest
> > changes in jdk11u:
> > cl : Command line error D8016 : '/RTC1' and '/O1' command-line
> > options are incompatible
> > *** [Lib-jdk.hotspot.agent.gmk:54: /output-jdk11-
> > fastdebug/support/modules_libs/jdk.hotspot.agent/saproc.dll] Error
> > 1
> >  
> > I guess this is related to the backport of
> > http://hg.openjdk.java.net/jdk-updates/jdk11u/rev/5dd4ef1d6ce9
> >  
> > Can you take a look, please?
> 
> Unfortunately I don't have a system to reproduce this on. Looking at
> the documentation of /RTC1[1] it's pointed out that it should only be
> enabled for debug builds. This suggests we need to add this flag only
> for slowdebug builds. It's being added here:
> 
http://hg.openjdk.java.net/jdk-updates/jdk11u/file/4675b75ee535/make/lib/Lib-jdk.hotspot.agent.gmk#l47
> 
> That is, we no longer can add that flag unconditionally. I've filed
> this bug:
> https://bugs.openjdk.java.net/browse/JDK-8212110
> 
> I'll see if I can come up with a patch which you can test.
> 
> Thanks,
> Severin
> 
> [1] https://msdn.microsoft.com/en-us/library/8wtf2dfz.aspx
>  
> > Best regards,
> > Martin
> >  
> 
>