[11u] RFR(M) 8210754: print_location is not reliable enough (printing register info)

Doerr, Martin martin.doerr at sap.com
Thu Oct 18 15:40:52 UTC 2018


Hi,

thanks for approving the backport of this change to get better hs_err files (step "printing register info").

I need a review because it doesn't apply cleanly.
I had to move ClassLoaderDataGraph::is_valid to classLoaderData.cpp omitting the new assertion because JDK-8209645: "Split ClassLoaderData and ClassLoaderDataGraph into separate files" is only in jdk/jdk.
In addition, I had to make a trivial signature adaptation change in os.cpp because JDK-8207779: "Method::is_valid_method() compares 'this' with NULL" is only in jdk/jdk.

Change was built and tested by our internal tests: Windows (32 and 64 bit), linux (x86_64, ppc64, ppc64le, s390), AIX, solaris (SPARC), MacOS
I also did a little manual testing by injecting crashing code.

Please review jdk11u webrev:
http://cr.openjdk.java.net/~mdoerr/8210754_print_location/webrev_jdk11u.00/

Best regards,
Martin



More information about the jdk-updates-dev mailing list