[11u] RFR(M) 8210754: print_location is not reliable enough (printing register info)

[Doerr, Martin]

Hi Thomas,

thank you for reviewing. Pushed.

Best regards,
Martin


From: Stuefe, Thomas
Sent: Donnerstag, 18. Oktober 2018 21:00
To: Doerr, Martin <martin.doerr at sap.com>; jdk-updates-dev at openjdk.java.net
Cc: Coleen Phillimore (coleen.phillimore at oracle.com) <coleen.phillimore at oracle.com>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Subject: RE: [11u] RFR(M) 8210754: print_location is not reliable enough (printing register info)

Hi Martin,

Seems okay, I compared it with the upstream change and cannot see anything wrong.

Cheers, Thomas

From: Doerr, Martin
Sent: Donnerstag, 18. Oktober 2018 17:41
To: jdk-updates-dev at openjdk.java.net<mailto:jdk-updates-dev at openjdk.java.net>
Cc: Stuefe, Thomas <thomas.stuefe at sap.com<mailto:thomas.stuefe at sap.com>>; Coleen Phillimore (coleen.phillimore at oracle.com<mailto:coleen.phillimore at oracle.com>) <coleen.phillimore at oracle.com<mailto:coleen.phillimore at oracle.com>>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>
Subject: [11u] RFR(M) 8210754: print_location is not reliable enough (printing register info)

Hi,

thanks for approving the backport of this change to get better hs_err files (step "printing register info").

I need a review because it doesn't apply cleanly.
I had to move ClassLoaderDataGraph::is_valid to classLoaderData.cpp omitting the new assertion because JDK-8209645: "Split ClassLoaderData and ClassLoaderDataGraph into separate files" is only in jdk/jdk.
In addition, I had to make a trivial signature adaptation change in os.cpp because JDK-8207779: "Method::is_valid_method() compares 'this' with NULL" is only in jdk/jdk.

Change was built and tested by our internal tests: Windows (32 and 64 bit), linux (x86_64, ppc64, ppc64le, s390), AIX, solaris (SPARC), MacOS
I also did a little manual testing by injecting crashing code.

Please review jdk11u webrev:
http://cr.openjdk.java.net/~mdoerr/8210754_print_location/webrev_jdk11u.00/

Best regards,
Martin